Add metadata for more modules and document metrics emitted #13965
Conversation
zeitlinger
left a comment
zeitlinger
left a comment
There was a problem hiding this comment.
great stuff - do you have an idea if we can also generate the spring metadata out of this?
| # Runs selected Gradle test tasks to regenerate *.telemetry output for | ||
| # individual OpenTelemetry Java agent instrumentations. | ||
|
|
||
| set -euo pipefail |
There was a problem hiding this comment.
maybe this is getting too complicated for a shell script. maybe use python?
There was a problem hiding this comment.
this is just a helper script and the need for it should be temporary, but i agree it is getting a bit complex for bash (which is why I've included so many comments 😅).
I was hesitant to introduce python to this repo, but im open to rewriting this to make it easier to grok
There was a problem hiding this comment.
I was hesitant to introduce python to this repo
it's ok with me (if you want to)
| @@ -0,0 +1,4 @@ | |||
| description: > | |||
| Couchbase instrumentation is owned upstream. This Couchbase instrumentation manipulates the | |||
There was a problem hiding this comment.
I think we don't need to provide the details on how exactly the instrumentation works as it requires the reader to know how tracing works in couchbase to make sense of it. Maybe we could be a bit more vague and just say we automatically enable the instrumentation that is provided by the couchbase.
Couchbase instrumentation is owned by the Couchbase project. This instrumentation automatically configures the instrumentation provided by the Couchbase.
| @@ -0,0 +1,6 @@ | |||
| description: This instrumentation provides support for Apache Camel and generates spans for each route execution. | |||
There was a problem hiding this comment.
should we also mention that this instrumentation is only for 2.x and that in 3.x instrumentation is built into camel (I think our instrumentation is based on instrumentation for a later version).
There was a problem hiding this comment.
yes i think that is good idea
…mentation into continue-modules
…mentation into continue-modules
4 participants
Related to #13468
Now that we can intercept metrics, I went through and found all the instrumentation modules that emit metrics by default and enabled the gathering on them. There are still many modules that emit metrics behind configuration flags, and I will followup with a strategy for how we can handle the case for telemetry gated by configuration options, and then enable the metric gathering on those remaining modules.
Also added more descriptions and configuration documentation, and refactored the collect script.