Add descriptions for httpclients and other instrumentations #14248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentation into enable-more-metrics
…mentation into enable-more-metrics
…mentation into enable-more-metrics
jaydeluca
commented
Jul 16, 2025
| // required on jdk17 | ||
| jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED") | ||
| jvmArgs("-XX:+IgnoreUnrecognizedVMOptions") | ||
| jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true") |
Member
Author
There was a problem hiding this comment.
as far as I can tell, this configuration is not used in this instrumentation
laurit
reviewed
Jul 16, 2025
docs/instrumentation-list.yaml
Outdated
| - name: url.full | ||
| type: STRING | ||
| - name: apache-httpclient-5.0 | ||
| description: This instrumentation provides CLIENT spans and metrics for version |
Contributor
There was a problem hiding this comment.
akka instrumentation uses enables while here you use provides, should we use the same wording?
Member
Author
There was a problem hiding this comment.
yes i think we should try and be consistent, i'll update accordingly
laurit
reviewed
Jul 16, 2025
laurit
reviewed
Jul 16, 2025
laurit
reviewed
Jul 16, 2025
laurit
reviewed
Jul 16, 2025
laurit
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468
Adds descriptions and captures telemetry for another batch of instrumentations