-
Notifications
You must be signed in to change notification settings - Fork 1k
Add descriptions for httpclients and other instrumentations #14248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c6f8dd5
more
jaydeluca 4c8e646
Merge branch 'main' of github.com:jaydeluca/opentelemetry-java-instru…
jaydeluca 7212100
Merge branch 'main' of github.com:jaydeluca/opentelemetry-java-instru…
jaydeluca c313a12
descriptions
jaydeluca 0467faf
update
jaydeluca 15c1fd0
Merge branch 'main' of github.com:jaydeluca/opentelemetry-java-instru…
jaydeluca c9bad11
merge main
jaydeluca ab83554
be consistent with wording in descriptions, address code review comments
jaydeluca e1ff9a8
fix capitalization
jaydeluca fe973ca
Merge branch 'main' into enable-more-metrics
jaydeluca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| description: This instrumentation provides SERVER spans and metrics for the ActiveJ HTTP server. | ||
| description: This instrumentation enables SERVER spans and metrics for the ActiveJ HTTP server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation enables CLIENT and SERVER spans and metrics for the Akka HTTP client and server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| description: This instrumentation provides CLIENT spans and metrics for the Apache HttpAsyncClient. | ||
| description: This instrumentation enables CLIENT spans and metrics for the Apache HttpAsyncClient. |
2 changes: 1 addition & 1 deletion
2
instrumentation/apache-httpclient/apache-httpclient-2.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| description: This instrumentation provides CLIENT spans and metrics for versions 2 and 3 of the Apache HttpClient. | ||
| description: This instrumentation enables CLIENT spans and metrics for versions 2 and 3 of the Apache HttpClient. |
2 changes: 1 addition & 1 deletion
2
instrumentation/apache-httpclient/apache-httpclient-4.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| description: This instrumentation provides CLIENT spans and metrics for version 4 of the Apache HttpClient. | ||
| description: This instrumentation enables CLIENT spans and metrics for version 4 of the Apache HttpClient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
instrumentation/apache-httpclient/apache-httpclient-5.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation enables CLIENT spans and metrics for version 5 of the Apache HttpClient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
instrumentation/apache-httpclient/apache-httpclient-5.2/library/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation enables CLIENT spans and metrics for the Apache HttpAsyncClient. |
1 change: 1 addition & 0 deletions
1
instrumentation/apache-httpclient/apache-httpclient-5.2/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation provides a library integration that enables CLIENT spans and metrics for the Apache HttpClient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| description: > | ||
| This instrumentation does not emit telemetry on its own. Instead, it augments existing SERVER | ||
| spans and HTTP server metrics with the HTTP route and Shenyu specific attributes. | ||
| configurations: | ||
| - name: otel.instrumentation.apache-shenyu.experimental-span-attributes | ||
| description: Enables experimental span attributes for Apache Shenyu instrumentation. | ||
| description: > | ||
| Enables experimental `apache-shenyu.meta.` prefixed span attributes `app-name`, | ||
| `service-name`, `context-path`, `param-types`, `id`, `method-name`, `rpc-type`, `path` and | ||
| `rpc-ext`. | ||
| type: boolean | ||
| default: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation enables CLIENT and SERVER spans and metrics for the Armeria HTTP client and server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation enables CLIENT and SERVER spans and metrics for the Armeria gRPC client and server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
instrumentation/async-http-client/async-http-client-1.9/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation enables CLIENT spans and metrics for version 1 of the AsyncHttpClient (AHC) HTTP client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
instrumentation/async-http-client/async-http-client-2.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation enables CLIENT spans and metrics for version 2 of the AsyncHttpClient (AHC) HTTP client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
instrumentation/elasticsearch/elasticsearch-api-client-7.16/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| description: This instrumentation provides client spans for Elasticsearch API client requests for | ||
| description: This instrumentation enables client spans for Elasticsearch API client requests for | ||
| version 7 of the client. Versions 8.10 and later have native support for OpenTelemetry. |
4 changes: 2 additions & 2 deletions
4
instrumentation/elasticsearch/elasticsearch-rest-5.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| description: This instrumentation provides tracing for Elasticsearch REST clients. | ||
| description: This instrumentation enables tracing for Elasticsearch REST clients. | ||
| configurations: | ||
| - name: otel.instrumentation.elasticsearch.capture-search-query | ||
| description: | | ||
| Enable the capture of search query bodies. It is important to note that Elasticsearch queries | ||
| may contain personal or sensitive information. | ||
| type: boolean | ||
| default: false | ||
| default: false |
4 changes: 2 additions & 2 deletions
4
instrumentation/elasticsearch/elasticsearch-rest-6.4/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| description: This instrumentation provides tracing for Elasticsearch REST clients. | ||
| description: This instrumentation enables tracing for Elasticsearch REST clients. | ||
| configurations: | ||
| - name: otel.instrumentation.elasticsearch.capture-search-query | ||
| description: > | ||
| Enable the capture of search query bodies. It is important to note that Elasticsearch queries | ||
| may contain personal or sensitive information. | ||
| type: boolean | ||
| default: false | ||
| default: false |
4 changes: 2 additions & 2 deletions
4
instrumentation/elasticsearch/elasticsearch-rest-7.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| description: This instrumentation provides tracing for Elasticsearch REST clients. | ||
| description: This instrumentation enables tracing for Elasticsearch REST clients. | ||
| configurations: | ||
| - name: otel.instrumentation.elasticsearch.capture-search-query | ||
| description: > | ||
| Enable the capture of search query bodies. It is important to note that Elasticsearch queries | ||
| may contain personal or sensitive information. | ||
| type: boolean | ||
| default: false | ||
| default: false |
2 changes: 1 addition & 1 deletion
2
instrumentation/elasticsearch/elasticsearch-transport-5.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
instrumentation/elasticsearch/elasticsearch-transport-5.3/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
instrumentation/elasticsearch/elasticsearch-transport-6.0/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: > | ||
| This instrumentation for Finagle HTTP clients and servers ensures that telemetry is correctly | ||
| generated by the underlying Netty instrumentation. It augments existing telemetry by bridging the | ||
| gap between Finagle's abstractions and Netty's pipeline, primarily for context propagation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| description: This instrumentation for the Finatra web framework augments the telemetry generated by the underlying Netty instrumentation. It provides more specific, high-level context, such as route information, to the spans generated by Netty. |
2 changes: 1 addition & 1 deletion
2
instrumentation/kafka/kafka-clients/kafka-clients-0.11/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as I can tell, this configuration is not used in this instrumentation