Test javadoc #14253
Merged
Test javadoc #14253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
laurit
reviewed
Jul 16, 2025
.github/workflows/build-common.yml
Outdated
| - name: Build | ||
| # javadoc task fails sporadically fetching https://docs.oracle.com/javase/8/docs/api/ | ||
| run: ./gradlew check spdxSbom -x javadoc -x spotlessCheck -PskipTests=true ${{ inputs.no-build-cache && '--no-build-cache' || '' }} | ||
| run: ./gradlew check spdxSbom -x spotlessCheck -PskipTests=true ${{ inputs.no-build-cache && '--no-build-cache' || '' }} |
Contributor
There was a problem hiding this comment.
Apparently this still doesn't trigger javadoc. I guess it originally used assemble instead of check when javadoc was disabled. Try adding javadoc to the tasks. Alternatively could run javadoc as a separate step that doesn't block merge if it is still flaky.
laurit
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since we added this exclusion, maybe the situation has improved by now??