Add descriptions and metadata for spring modules #14309
Conversation
…mentation into spring-metadata
| excludeTestsMatching("*CustomSpanEventTest") | ||
| } | ||
|
|
||
| systemProperty("collectMetadata", findProperty("collectMetadata")?.toString() ?: "false") |
There was a problem hiding this comment.
this seems repetitive - maybe we can add it to https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/conventions/src/main/kotlin/otel.javaagent-testing.gradle.kts
There was a problem hiding this comment.
First I need to go through and review all of the module gradle files so that I can tag the resulting telemetry accordingly, based on the configuration flags. Once we have annotated all the test suites, we can remove the individual collectMetadata and collectSpans from the individual files and add them globally like you suggest
There was a problem hiding this comment.
you could also pass flags like here to indicate which modules support this:
| default: false | ||
| - name: otel.instrumentation.messaging.experimental.receive-telemetry.enabled | ||
| description: Enables experimental receive telemetry for AWS SDK instrumentation. | ||
| description: > |
There was a problem hiding this comment.
we probably want to have a glossary of all config properties like we have for all semantic attributes at some point - to avoid this repetition
There was a problem hiding this comment.
yea, weaver uses references to attributes and other things defined in registries, so I imagine we'll eventually do something similar
…java-instrumentation into spring-metadata
…mentation into spring-metadata
3 participants
Part of #13468
Covers all of the spring modules, as well as the newly introduced openai instrumentation