Skip to content

Conversation

@otelbot
Copy link
Contributor

@otelbot otelbot bot commented Aug 5, 2025

This PR was created automatically by the metadata update workflow.

@otelbot otelbot bot requested a review from a team as a code owner August 5, 2025 09:51
Copy link
Member

@jaydeluca jaydeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is working as expected 🎉 This first run helps cleanup some discrepancies from me running it locally. I will submit a PR later today to re-add the missing spring-jms and kafka to the telemetry collection along with some other changes

javaagent:
- org.apache.kafka:kafka-streams:[0.11.0.0,)
kotlinx:
- name: kotlinx-coroutines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some local directory structures that added this when running locally, so this automation identified and fixed that 👍

- name: messaging.operation
type: STRING
- name: messaging.system
type: STRING
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both this spring-jms-6.0 change and the one for spring-kafka-2.7 identified modules that are missing from the instrumentations list (but i had the telemetry files generated locally). I will add those two modules back into the list in another PR

@trask trask merged commit 2c9bf8c into main Aug 5, 2025
89 checks passed
@trask trask deleted the metadata-update-main branch August 5, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants