Update spring boot gradle plugin in smoke test image #14488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Aug 21, 2025
|
|
||
| id("com.google.cloud.tools.jib") | ||
| id("org.springframework.boot") version "2.6.15" | ||
| id("org.springframework.boot") version "3.5.4" |
Contributor
Author
There was a problem hiding this comment.
apparently newer plugin along with older spring dependencies produces a working application
laurit
commented
Aug 21, 2025
| logging.level.root=WARN | ||
| logging.level.io.opentelemetry=INFO | ||
| logging.pattern.console=%-5level [%t] %C{1.}: %msg trace_id=%X{trace_id}%n | ||
| logging.pattern.console=%-5level [%t] %C: %msg trace_id=%X{trace_id}%n |
Contributor
Author
There was a problem hiding this comment.
pattern failed to parse when spring dependencies were also updated
Member
There was a problem hiding this comment.
does this mean that updating the plugin is forcing the spring dependency updates?
Contributor
Author
There was a problem hiding this comment.
Not really, I just tried what happens if I also update the spring boot version in the app and got an exception. We could consider updating the spring dependencies too, as far as I understand there isn't anything that would prevent us from running the test with spring boot 3 instead of 2.
trask
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.