Add support for library links in metadata #14622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
approved these changes
Sep 10, 2025
| InstrumentationMetaData internalMetadata = | ||
| new InstrumentationMetaData( | ||
| null, InstrumentationClassification.INTERNAL.toString(), null, null); | ||
| null, InstrumentationClassification.INTERNAL.toString(), null, null, null); |
Contributor
There was a problem hiding this comment.
[minor] in a follow-up PR, switching to a builder pattern might help to make it more readable as there is now 5 parameters.
Member
Author
There was a problem hiding this comment.
i agree, created #14623 to track that work in a followup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468
Closes #14233
Referenced the links used in the Supported Libraries page
I will continue populating the remaining metadata files in followup PRs as to not bloat this changeset too much more