Skip to content

Improve dubbo network type assertion #14717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2025
Merged

Improve dubbo network type assertion #14717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e212a7c
Improve dubbo network type assertion
laurit Sep 19, 2025
ce191ea
Merge branch 'main' into dubbo-network-type
steverao Sep 23, 2025
309ff0a
fix failing assertion
laurit Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions instrumentation/apache-dubbo-2.7/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ testing {
}

tasks.withType<Test>().configureEach {
systemProperty("testLatestDeps", findProperty("testLatestDeps") as Boolean)
jvmArgs("-XX:+IgnoreUnrecognizedVMOptions")
// to suppress non-fatal errors on jdk17
jvmArgs("--add-opens=java.base/java.math=ALL-UNNAMED")
Expand Down
90 changes: 38 additions & 52 deletions ...ng/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/AbstractDubboTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.net.InetAddress;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import java.util.function.Consumer;
import org.apache.dubbo.common.utils.NetUtils;
import org.apache.dubbo.config.ApplicationConfig;
import org.apache.dubbo.config.ProtocolConfig;
Expand All @@ -38,6 +39,7 @@
import org.apache.dubbo.config.bootstrap.DubboBootstrap;
import org.apache.dubbo.rpc.service.GenericService;
import org.assertj.core.api.AbstractAssert;
import org.assertj.core.api.AbstractStringAssert;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -143,23 +145,11 @@ void testApacheDubboBase() throws ReflectiveOperationException {
satisfies(SERVER_PORT, k -> k.isInstanceOf(Long.class)),
satisfies(
NETWORK_PEER_ADDRESS,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val -> assertThat(val).isInstanceOf(String.class))),
k -> assertLatestDeps(k, a -> a.isInstanceOf(String.class))),
satisfies(
NETWORK_PEER_PORT,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val -> assertThat(val).isInstanceOf(Long.class))),
satisfies(
NETWORK_TYPE,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val -> assertThat(val).isEqualTo("ipv4"),
val -> assertThat(val).isEqualTo("ipv6")))),
k -> assertLatestDeps(k, a -> a.isInstanceOf(Long.class))),
satisfies(NETWORK_TYPE, AbstractDubboTest::assertNetworkType)),
span ->
span.hasName(
"io.opentelemetry.instrumentation.apachedubbo.v2_7.api.HelloService/hello")
Expand All @@ -174,8 +164,7 @@ void testApacheDubboBase() throws ReflectiveOperationException {
"io.opentelemetry.instrumentation.apachedubbo.v2_7.api.HelloService"),
equalTo(RPC_METHOD, "hello"),
satisfies(NETWORK_PEER_ADDRESS, k -> k.isInstanceOf(String.class)),
satisfies(NETWORK_PEER_PORT, k -> k.isInstanceOf(Long.class)),
satisfies(NETWORK_TYPE, AbstractAssert::isNull))));
satisfies(NETWORK_PEER_PORT, k -> k.isInstanceOf(Long.class)))));

testing()
.waitAndAssertMetrics(
Expand Down Expand Up @@ -227,14 +216,7 @@ void testApacheDubboBase() throws ReflectiveOperationException {
SERVER_PORT, k -> k.isInstanceOf(Long.class)),
satisfies(
NETWORK_TYPE,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val ->
assertThat(val).isEqualTo("ipv4"),
val ->
assertThat(val)
.isEqualTo("ipv6"))))))));
AbstractDubboTest::assertNetworkType))))));
}

@Test
Expand Down Expand Up @@ -294,23 +276,11 @@ void testApacheDubboTest()
satisfies(SERVER_PORT, k -> k.isInstanceOf(Long.class)),
satisfies(
NETWORK_PEER_ADDRESS,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val -> assertThat(val).isInstanceOf(String.class))),
k -> assertLatestDeps(k, a -> a.isInstanceOf(String.class))),
satisfies(
NETWORK_PEER_PORT,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val -> assertThat(val).isInstanceOf(Long.class))),
satisfies(
NETWORK_TYPE,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val -> assertThat(val).isEqualTo("ipv4"),
val -> assertThat(val).isEqualTo("ipv6")))),
k -> assertLatestDeps(k, a -> a.isInstanceOf(Long.class))),
satisfies(NETWORK_TYPE, AbstractDubboTest::assertNetworkType)),
span ->
span.hasName(
"io.opentelemetry.instrumentation.apachedubbo.v2_7.api.HelloService/hello")
Expand All @@ -326,13 +296,18 @@ void testApacheDubboTest()
equalTo(RPC_METHOD, "hello"),
satisfies(NETWORK_PEER_ADDRESS, k -> k.isInstanceOf(String.class)),
satisfies(NETWORK_PEER_PORT, k -> k.isInstanceOf(Long.class)),
// this attribute is not filled reliably, it is either null or
// "ipv4"/"ipv6"
satisfies(
NETWORK_TYPE,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val -> assertThat(val).isEqualTo("ipv4"),
val -> assertThat(val).isEqualTo("ipv6"))))));
assertLatestDeps(
k,
a ->
a.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val -> assertThat(val).isEqualTo("ipv4"),
val -> assertThat(val).isEqualTo("ipv6")))))));

testing()
.waitAndAssertMetrics(
Expand Down Expand Up @@ -384,13 +359,24 @@ void testApacheDubboTest()
SERVER_PORT, k -> k.isInstanceOf(Long.class)),
satisfies(
NETWORK_TYPE,
k ->
k.satisfiesAnyOf(
val -> assertThat(val).isNull(),
val ->
assertThat(val).isEqualTo("ipv4"),
val ->
assertThat(val)
.isEqualTo("ipv6"))))))));
AbstractDubboTest::assertNetworkType))))));
}

static void assertNetworkType(AbstractStringAssert<?> stringAssert) {
assertLatestDeps(
stringAssert,
a ->
a.satisfiesAnyOf(
val -> assertThat(val).isEqualTo("ipv4"),
val -> assertThat(val).isEqualTo("ipv6")));
}

static void assertLatestDeps(
AbstractAssert<?, ?> assertion, Consumer<AbstractAssert<?, ?>> action) {
if (Boolean.getBoolean("testLatestDeps")) {
action.accept(assertion);
} else {
assertion.isNull();
}
}
}
Loading