make jdbc indy-ready #14764
make jdbc indy-ready #14764
Conversation
…nstrumentation into indy-jdbc
…nstrumentation into indy-jdbc
…nstrumentation into indy-jdbc
…nstrumentation into indy-jdbc
| DbRequest request; | ||
| if (sql != null) { | ||
| request = DbRequest.create(statement, sql); | ||
| } else if (preparedStatement != null) { | ||
| Map<String, String> parameters = JdbcData.getParameters(preparedStatement); | ||
| request = DbRequest.create(preparedStatement, parameters); | ||
| } else { | ||
| // batch | ||
| request = createBatchRequest(statement); | ||
| } |
There was a problem hiding this comment.
perhaps it would be better for start to accept Supplier<DbRequest> so that the request creation could be moved to startStatement etc.
There was a problem hiding this comment.
I'll try to do that, but I see two potential issues:
- extra allocation due to having to create an supplier instance on each call
- we might not be able to use lambdas unless the instrumented bytecode is java 8 or later
We could however maybe use an enum rather than an heuristic based on null arguments to split the 3 types of calls.
There was a problem hiding this comment.
extra allocation due to having to create an supplier instance on each call
This isn't really an issue because we need to create a bunch of objects for each span. I guess you could try you could try subclassing the JdbcAdviceScope If you wish to avoid the supplier or use a stateless lambda, but probably not worth the effort.
we might not be able to use lambdas unless the instrumented bytecode is java 8 or later
that is not an issue since the code is inside JdbcAdviceScope
There was a problem hiding this comment.
I was thinking of pushing the Supplier creation directly into the advice, but you are right keeping it JdbcAdviceScope already makes things easier to read. Once everything is running with indy advices we could even directly remove those 3 intermediate methods that are called from advices.
…nstrumentation into indy-jdbc
2 participants
Part of #13031 for jdbc instrumentation