Fix nullaway convention plugin

[jaydeluca]

Fixes #14771

While doing some development locally I realized that changes I was making to test code was not being reflected, and I noticed that we had an actual test failure merged in main that was not failing in CI.

I think previously we were disabling the entire module instead of just nullaway/errorprone. This change fixes that.

I think every module that uses nullaway might not be actually executing tests as of right now. This should fix it.

[trask]

we'd only disable errorprone for test source if nullaway is enabled for the module?

[jaydeluca]

yes, we are only disabling error prone for test sources if the module has the plugin installed viaid("otel.nullaway-conventions")

[trask]

oh, so errorprone will still run on those test source, just via a different mechanism?

[jaydeluca]

no, this will turn error prone off entirely for those particular test sources. I assumed it would be ok to not run it on test code, but maybe that was an incorrect assumption on my part. I couldn't figure out a way to just disable nullaway without disabling errorprone entirely, but I can keep digging

[zeitlinger]

does this work

tasks {
  withType<JavaCompile>().configureEach {
    options.errorprone.nullaway {
      if (name.contains("test", ignoreCase = true)) {
        disable()
      } else {
        error()
      }
      customInitializerAnnotations.add("org.openjdk.jmh.annotations.Setup")
      excludedFieldAnnotations.add("org.mockito.Mock")
      excludedFieldAnnotations.add("org.mockito.InjectMocks")
    }
  }
}