Apply otel.japicmp-conventions centrally in otel.publish-conventions #14869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added otel.japicmp-conventions to otel.publish-conventions.gradle.kts to apply it centrally - Removed explicit otel.japicmp-conventions from individual stable module build files - Updated japicmp-conventions to only apply to projects with a jar task (excludes BOMs/platforms) - Applied spotless formatting fixes to maintain consistent code style Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
[WIP] Try to add
Apply otel.japicmp-conventions centrally in otel.publish-conventions
Oct 3, 2025
otel.japicmp-conventions centrally
Copilot finished work on behalf of
trask
October 3, 2025 01:22
github-actions
bot
added
the
test native
trask
reviewed
Oct 3, 2025
conventions/src/main/kotlin/io.opentelemetry.instrumentation.base.gradle.kts
Show resolved
Hide resolved
Co-authored-by: trask <[email protected]>
Copilot finished work on behalf of
trask
October 3, 2025 03:18
trask
reviewed
Oct 3, 2025
There was a problem hiding this comment.
the changes in this file makes a lot more sense when you select "hide whitespace" from the gear icon above (because of the extra level of indentation introduced)
trask
approved these changes
Oct 3, 2025
laurit
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otel.japicmp-conventionstootel.publish-conventions.gradle.ktsto apply it centrallyotel.japicmp-conventionsfrom individual module build filesotel.japicmp-conventionsto skip projects without a jar task (like BOMs)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.