Add configurable OpenTelemetry kafka-clients interceptors #14929

trask · 2025-10-09T03:55:11Z

This PR

Adds OpenTelemetryConsumerInterceptor and OpenTelemetryProducerInterceptor which accept a KafkaTelemetry instance
Deprecates TracingConsumerInterceptor and TracingProducerInterceptor

Went with new class names since we want to get away from "Tracing*" anyways.

Fixes #6291

Supersedes #14870

Co-authored-by: trask <[email protected]>

…wards compatibility, move KafkaTelemetrySupplier Co-authored-by: trask <[email protected]>

…recated Co-authored-by: trask <[email protected]>

…src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingConsumerInterceptor.java

…src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingProducerInterceptor.java

otelbot-java-instrumentation · 2025-10-09T19:10:01Z

🔧 The result from spotlessApply was committed to the PR branch.

trask · 2025-10-09T23:09:50Z

...a/io/opentelemetry/instrumentation/kafkaclients/v2_6/AbstractDeprecatedInterceptorsTest.java

this is a copy of the original AbstractInterceptorsTest.java, to continue testing the deprecated classes until we remove them

trask · 2025-10-09T23:10:18Z

...emetry/instrumentation/kafkaclients/v2_6/DeprecatedInterceptorsSuppressReceiveSpansTest.java

this is a copy of the original InterceptorsSuppressReceiveSpansTest.java, to continue testing the deprecated classes until we remove them

trask · 2025-10-09T23:10:36Z

...test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/DeprecatedInterceptorsTest.java

this is a copy of the original InterceptorsTest.java, to continue testing the deprecated classes until we remove them

...entelemetry/instrumentation/kafkaclients/v2_6/internal/OpenTelemetryConsumerInterceptor.java

...entelemetry/instrumentation/kafkaclients/v2_6/internal/OpenTelemetryProducerInterceptor.java

trask · 2025-10-10T22:38:23Z

...entelemetry/instrumentation/kafkaclients/v2_6/internal/OpenTelemetryMetricsReporterTest.java


  @Test
  void badConfig() {
-    Assumptions.assumeFalse(Boolean.getBoolean("testLatestDeps"));


this seems to not be needed (anymore)

otelbot-java-instrumentation · 2025-10-10T23:33:16Z

🔧 The result from spotlessApply was committed to the PR branch.

otelbot-java-instrumentation · 2025-10-11T00:21:05Z

🔧 The result from spotlessApply was committed to the PR branch.

Copilot AI and others added 22 commits October 3, 2025 00:56

Initial plan

2a012ae

Initial plan for refactoring kafka interceptors

34d68ec

Co-authored-by: trask <[email protected]>

Refactor kafka interceptors to be configurable

3b68915

Co-authored-by: trask <[email protected]>

Update README with interceptor configuration documentation

ce0eafc

Co-authored-by: trask <[email protected]>

Follow OpenTelemetryMetricsReporter pattern for property validation

b187791

Co-authored-by: trask <[email protected]>

Avoid changing KafkaTelemetry - move config keys to interceptors

85ec089

Co-authored-by: trask <[email protected]>

Use OpenTelemetrySupplier instead of KafkaTelemetrySupplier

5f6294b

Co-authored-by: trask <[email protected]>

Clean up unused code and use imports instead of FQCN

e5ca107

Co-authored-by: trask <[email protected]>

Add helper methods to KafkaTelemetry for interceptor config

e791fc8

Co-authored-by: trask <[email protected]>

Include INTERCEPTOR_CLASSES_CONFIG in helper methods

97cbf9d

Co-authored-by: trask <[email protected]>

Use KafkaTelemetrySupplier to pass exact KafkaTelemetry instance

4f3d30d

Co-authored-by: trask <[email protected]>

Remove experimental from config key, simplify fallback, add test

a31210c

Co-authored-by: trask <[email protected]>

Refactor kafka-clients interceptors to be configurable

84e69ad

Co-authored-by: trask <[email protected]>

Restore system property checks in fallback with TODO comment

5419f03

Co-authored-by: trask <[email protected]>

Use import instead of FQCN for Supplier in test

f4e568a

Co-authored-by: trask <[email protected]>

Apply suggestions from code review

82248c4

./gradlew spotlessApply

f1e7dde

Create new OpenTelemetry interceptors, keep old Tracing ones for back…

7703b1d

…wards compatibility, move KafkaTelemetrySupplier Co-authored-by: trask <[email protected]>

Mark TracingConsumerInterceptor and TracingProducerInterceptor as dep…

95d1723

…recated Co-authored-by: trask <[email protected]>

Update instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/…

3fdd463

…src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingConsumerInterceptor.java

Update instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/…

f72ae47

…src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingProducerInterceptor.java

Test deprecated classes until they're removed

2bc5492

trask mentioned this pull request Oct 9, 2025

Add configurable OpenTelemetry kafka-clients interceptors #14870

Closed

trask and others added 4 commits October 9, 2025 10:24

fix

f24a0a4

fix

45c7510

fix

85aaaaa

./gradlew spotlessApply

9b9b075

trask added 2 commits October 9, 2025 14:01

fix

6aa6306

fix

a541ee6

trask added 3 commits October 9, 2025 16:15

docs

06184d1

internal

30bc6dd

simplify

b207b25

trask commented Oct 10, 2025

View reviewed changes

trask added 9 commits October 10, 2025 11:13

Apply suggestions from code review

a2b44cc

KafkaHelper

d861b88

fixes

3c4f97f

split

ff96054

split2

61813b5

split test

41c767c

more

810c222

up

a2286d8

up

536c1cd

trask commented Oct 10, 2025

View reviewed changes

trask added 2 commits October 10, 2025 16:23

fix

bbd21cb

up

385bc15

trask added 3 commits October 10, 2025 16:35

up

84c9212

up

686de0c

up

eb7ecf9

trask force-pushed the kafka-config branch from 4ddc69f to eb7ecf9 Compare October 10, 2025 23:45

trask and others added 4 commits October 10, 2025 16:51

up

3fe741b

revert

4f58c8d

more

45c3e11

./gradlew spotlessApply

96bc1c9

trask added 2 commits October 10, 2025 18:12

javadoc

44975a6

Merge remote-tracking branch 'upstream/main' into kafka-config

d31e213

trask marked this pull request as ready for review October 11, 2025 02:29

trask requested a review from a team as a code owner October 11, 2025 02:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add configurable OpenTelemetry kafka-clients interceptors #14929

Add configurable OpenTelemetry kafka-clients interceptors #14929

trask commented Oct 9, 2025 •

edited

Loading

Uh oh!

otelbot-java-instrumentation bot commented Oct 9, 2025

Uh oh!

trask Oct 9, 2025

Uh oh!

trask Oct 9, 2025

Uh oh!

trask Oct 9, 2025

Uh oh!

Uh oh!

Uh oh!

trask Oct 10, 2025

Uh oh!

otelbot-java-instrumentation bot commented Oct 10, 2025

Uh oh!

otelbot-java-instrumentation bot commented Oct 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add configurable OpenTelemetry kafka-clients interceptors #14929

Are you sure you want to change the base?

Add configurable OpenTelemetry kafka-clients interceptors #14929

Conversation

trask commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

otelbot-java-instrumentation bot commented Oct 9, 2025

Uh oh!

trask Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

trask Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

trask Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

trask Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

otelbot-java-instrumentation bot commented Oct 10, 2025

Uh oh!

otelbot-java-instrumentation bot commented Oct 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

trask commented Oct 9, 2025 •

edited

Loading