Skip to content

Update aws sdk1 semconv #15094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2025
Merged

Update aws sdk1 semconv #15094

merged 3 commits into from
Oct 22, 2025

Conversation

@laurit
Copy link
Contributor

@laurit laurit commented Oct 22, 2025 •
edited by trask
Loading

I believe that unlike aws sdk2 instrumetnation all the affected attributes were emitted only with the experimental flag.

Attribute Removals (only affects usage of otel.instrumentation.aws-sdk.experimental-span-attributes=true)

1. aws.bucket.name (S3)

  • Replacement: aws.s3.bucket (now emitted by default, even without experimental flag)

2. aws.queue.url (SQS)

  • Replacement: aws.sqs.queue.url (now emitted by default, even without experimental flag)

3. aws.stream.name (Kinesis)

  • Replacement: aws.kinesis.stream_name (now emitted by default, even without experimental flag)

4. aws.table.name (DynamoDB)

  • Replacement: aws.dynamodb.table_names (now emitted by default, even without experimental flag)

@laurit laurit marked this pull request as ready for review October 22, 2025 16:11
@laurit laurit requested a review from a team as a code owner October 22, 2025 16:11
@trask
Copy link
Member

trask commented Oct 22, 2025

I think it's still good to mark this as a breaking change, I'll write the summary

@github-actions
Copy link
Contributor

⚠️ Breaking Change Documentation Required

This PR has been labeled as a breaking change. Please ensure you provide the following information:

Migration Notes Required

Please add detailed migration notes to help users understand:

  • What is changing and why
  • How to update their code/configuration
  • Any alternative approaches if applicable
  • Code examples showing before/after usage

Checklist

  • Migration notes added to the PR description
  • Breaking change is documented in the changelog entry for the next release
  • Consider if this change requires a major version bump

Your migration notes will be included in the release notes to help users upgrade smoothly. The more detailed and helpful they are, the better the user experience will be.

This comment was automatically generated because the breaking change label was applied to this PR.

@trask trask mentioned this pull request Oct 22, 2025
Merged
@trask trask enabled auto-merge (squash) October 22, 2025 18:07
@trask trask merged commit b4e00bc into open-telemetry:main Oct 22, 2025
155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laurit @trask @jaydeluca