Skip to content

Fix tests on Windows #15153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Fix tests on Windows #15153

wants to merge 17 commits into from
+338 −87

Conversation

@trask
Copy link
Member

@trask trask commented Oct 27, 2025

No description provided.

trask
trask commented Oct 27, 2025
View reviewed changes
trask
trask commented Oct 27, 2025
View reviewed changes
trask added a commit to trask/opentelemetry-java-instrumentation that referenced this pull request Oct 27, 2025
@trask
Fix Ratpack HTTP client tests on Windows
ad8e582 
Disable connection error tests (unopened port and non-routable address) on Windows
due to different exception handling in Netty. Windows wraps connection exceptions in
AbstractChannel$AnnotatedConnectException with different messages, causing test
assertion failures even with existing exception unwrapping logic.

Fixes open-telemetry#15153
@trask trask mentioned this pull request Oct 27, 2025
Merged
trask
trask commented Oct 27, 2025
View reviewed changes
@trask trask force-pushed the windows branch 2 times, most recently from 2f4d7eb to fb5a0ad Compare October 28, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@trask