Disable JSP compile spans by default #15261
Conversation
| - name: jsp-2.3 | ||
| display_name: JSP (JavaServer Pages) | ||
| description: | | ||
| This instrumentation enables view spans for JSP page rendering and compilation (view spans are disabled by default). |
There was a problem hiding this comment.
@trask the jsp compile spans are enabled by default. Should we disable them?
|
| "io.opentelemetry.jsp-2.3", | ||
| JspCompilationContextInstrumentationSingletons::spanNameOnCompile) | ||
| .addAttributesExtractor(new CompilationAttributesExtractor()) | ||
| .setEnabled(ExperimentalConfig.get().viewTelemetryEnabled()) |
There was a problem hiding this comment.
view telemetry flag is usually used for view rendering but I think this is fine too
| attributes: [] | ||
| jsp: | ||
| - name: jsp-2.3 | ||
| display_name: JSP (JavaServer Pages) |
There was a problem hiding this comment.
Actually the instrumentation name is a bit misleading. It really applies only to jasper, which is the jsp engine used by tomcat and all (except liberty?) open source app servers. Weblogic and websphere have their own jsp engines. The view rendering part should work for all jsp engines, but the compilation part will probably make muzzle reject the instrumentation for non-jasper implementations. This is just a FYI.
3 participants
Disabling the JSP compile spans by default. They can be re-enabled using the
otel.instrumentation.common.experimental.view-telemetry.enabled=trueconfiguration flagMetadata updates are part of #14096 and #14128