From 04c8a4b74c2df7aa7e2437b268b4fbcdc1c6a921 Mon Sep 17 00:00:00 2001 From: Lauri Tulmin Date: Thu, 13 Nov 2025 14:05:25 +0200 Subject: [PATCH] Assert parent span of response span in dropwizard test --- .../instrumentation/dropwizard/DropwizardTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/instrumentation/dropwizard/dropwizard-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard/DropwizardTest.java b/instrumentation/dropwizard/dropwizard-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard/DropwizardTest.java index 2a01f94d8fe7..32555cb8b0a7 100644 --- a/instrumentation/dropwizard/dropwizard-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard/DropwizardTest.java +++ b/instrumentation/dropwizard/dropwizard-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard/DropwizardTest.java @@ -31,7 +31,6 @@ import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint; import io.opentelemetry.sdk.testing.assertj.SpanDataAssert; -import io.opentelemetry.sdk.trace.data.SpanData; import io.opentelemetry.sdk.trace.data.StatusData; import java.net.URI; import java.net.URISyntaxException; @@ -129,10 +128,9 @@ private static String getEndpointName(ServerEndpoint endpoint) { @Override protected SpanDataAssert assertResponseSpan( - SpanDataAssert span, SpanData parentSpan, String method, ServerEndpoint endpoint) { - span.satisfies(spanData -> assertThat(spanData.getName()).endsWith(".sendError")) + SpanDataAssert span, String method, ServerEndpoint endpoint) { + return span.satisfies(spanData -> assertThat(spanData.getName()).endsWith(".sendError")) .hasKind(INTERNAL); - return span; } public static class TestApp extends Application {