Skip to content

Assert parent span of response span in dropwizard test #15286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

Assert parent span of response span in dropwizard test #15286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c8a4b
Assert parent span of response span in dropwizard test
laurit Nov 13, 2025
e8579d8
Merge branch 'main' into dropwizard-parent-span
laurit Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...g/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard/DropwizardTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint;
import io.opentelemetry.sdk.testing.assertj.SpanDataAssert;
import io.opentelemetry.sdk.trace.data.SpanData;
import io.opentelemetry.sdk.trace.data.StatusData;
import java.net.URI;
import java.net.URISyntaxException;
Expand Down Expand Up @@ -129,10 +128,9 @@ private static String getEndpointName(ServerEndpoint endpoint) {

@Override
protected SpanDataAssert assertResponseSpan(
SpanDataAssert span, SpanData parentSpan, String method, ServerEndpoint endpoint) {
span.satisfies(spanData -> assertThat(spanData.getName()).endsWith(".sendError"))
SpanDataAssert span, String method, ServerEndpoint endpoint) {
return span.satisfies(spanData -> assertThat(spanData.getName()).endsWith(".sendError"))
.hasKind(INTERNAL);
return span;
}

public static class TestApp extends Application<Configuration> {
Expand Down
Loading