Update spring-kafka latestDep tests for 4.0 #15435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
approved these changes
Nov 24, 2025
instrumentation/spring/spring-kafka-2.7/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
trask
reviewed
Nov 24, 2025
Comment on lines
25
to
29
| if (latestDepTest) { | ||
| library("org.springframework.boot:spring-boot-starter-kafka:latest.release") | ||
| } else { | ||
| library("org.springframework.kafka:spring-kafka:2.7.0") | ||
| } |
Member
There was a problem hiding this comment.
is there no non-spring boot starter version now?
Contributor
There was a problem hiding this comment.
what if you leave library("org.springframework.kafka:spring-kafka:2.7.0") here and add
latestDepTestLibrary("org.springframework.boot:spring-boot-starter-kafka:latest.release") down below?
trask
reviewed
Nov 25, 2025
Comment on lines
46
to
48
| val springKafkaVersion = if (latestDepTest) "org.springframework.boot:spring-boot-starter-kafka:latest.release" else "org.springframework.kafka:spring-kafka:2.7.0" | ||
| val springBootVersion = if (latestDepTest) "latest.release" else "2.5.3" | ||
| implementation(springKafkaVersion) |
Member
There was a problem hiding this comment.
when it's a whole different artifact I think I prefer
if (latestDepTest) {
implementation("..")
else {
implementation("..")
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15429
The
BackgroundPreinitializingApplicationListenerignore is a common change amongst many of these modules, so that change is also present in some of the other PRs