Skip to content

Commit 01686cb

Browse files
committed
merge conflict
1 parent 5547c97 commit 01686cb

File tree

1 file changed

+8
-21
lines changed

1 file changed

+8
-21
lines changed

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/SamplerFactoryTest.java

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -175,26 +175,6 @@ void createInvalid(SamplerModel model, String expectedMessage) {
175175
.isEqualTo(expectedMessage);
176176
}
177177

178-
private static Stream<Arguments> createInvalidArguments() {
179-
return Stream.of(
180-
Arguments.of(
181-
new SamplerModel()
182-
.withCompositeDevelopment(
183-
new ExperimentalComposableSamplerModel()
184-
.withParentThreshold(
185-
new ExperimentalComposableParentThresholdSamplerModel())),
186-
"parent threshold sampler root is required but is null"));
187-
}
188-
189-
@ParameterizedTest
190-
@MethodSource("createInvalidArguments")
191-
void createInvalid(SamplerModel model, String expectedMessage) {
192-
assertThatThrownBy(() -> SamplerFactory.getInstance().create(model, context))
193-
.isInstanceOf(DeclarativeConfigException.class)
194-
.cause()
195-
.hasMessage(expectedMessage);
196-
}
197-
198178
private static Stream<Arguments> createInvalidArguments() {
199179
return Stream.of(
200180
Arguments.of(
@@ -206,7 +186,14 @@ private static Stream<Arguments> createInvalidArguments() {
206186
.withJaegerRemoteDevelopment(
207187
new ExperimentalJaegerRemoteSamplerModel()
208188
.withEndpoint("http://jaeger-remote-endpoint")),
209-
"jaeger remote sampler initial_sampler is required"));
189+
"jaeger remote sampler initial_sampler is required"),
190+
Arguments.of(
191+
new SamplerModel()
192+
.withCompositeDevelopment(
193+
new ExperimentalComposableSamplerModel()
194+
.withParentThreshold(
195+
new ExperimentalComposableParentThresholdSamplerModel())),
196+
"parent threshold sampler root is required but is null"));
210197
}
211198

212199
@Test

0 commit comments

Comments
 (0)