Skip to content

Commit 02290c2

Browse files
committed
update to latest with single file schema
1 parent b5e73dd commit 02290c2

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

api/incubator/src/testConvertToModel/java/io/opentelemetry/api/incubator/InstrumentationConfigUtilTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
import io.opentelemetry.api.incubator.config.InstrumentationConfigUtil;
1717
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
1818
import io.opentelemetry.sdk.extension.incubator.fileconfig.SdkConfigProvider;
19+
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalInstrumentationModel;
1920
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLanguageSpecificInstrumentationModel;
2021
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLanguageSpecificInstrumentationPropertyModel;
21-
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.InstrumentationModel;
2222
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
2323
import java.io.ByteArrayInputStream;
2424
import java.nio.charset.StandardCharsets;
@@ -133,7 +133,8 @@ private static ConfigProvider withInstrumentationConfig(
133133

134134
return SdkConfigProvider.create(
135135
new OpenTelemetryConfigurationModel()
136-
.withInstrumentationDevelopment(new InstrumentationModel().withJava(javaConfig)));
136+
.withInstrumentationDevelopment(
137+
new ExperimentalInstrumentationModel().withJava(javaConfig)));
137138
}
138139

139140
private static class Model {

sdk-extensions/incubator/build.gradle.kts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ dependencies {
6060
// ... proceed with normal sourcesJar, compileJava, etc
6161

6262
val configurationTag = "1.0.0-rc.1"
63-
val configurationRef = "be1a43de6745da73ce1b6339c34b1e260e5b135b" // Replace with commit SHA to point to experiment with a specific commit
63+
val configurationRef = "8826969b88d4ec720c3ebfe5c95b27aca5c238a9" // Replace with commit SHA to point to experiment with a specific commit
6464
val configurationRepoZip = "https://github.com/open-telemetry/opentelemetry-configuration/archive/$configurationRef.zip"
6565
val buildDirectory = layout.buildDirectory.asFile.get()
6666

@@ -88,7 +88,7 @@ val deleteTypeDescriptions by tasks.registering(Delete::class) {
8888
}
8989

9090
jsonSchema2Pojo {
91-
sourceFiles = setOf(file("$buildDirectory/configuration/schema"))
91+
sourceFiles = setOf(file("$buildDirectory/configuration/opentelemetry_configuration.json"))
9292
targetDirectory = file("$buildDirectory/generated/sources/js2p/java/main")
9393
targetPackage = "io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model"
9494

@@ -112,10 +112,6 @@ jsonSchema2Pojo {
112112

113113
// Append Model as suffix to the generated classes.
114114
classNameSuffix = "Model"
115-
116-
fileFilter = FileFilter {
117-
it.path.endsWith(".json")
118-
}
119115
}
120116

121117
val generateJsonSchema2Pojo = tasks.getByName("generateJsonSchema2Pojo")

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigurationParseTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalHttpClientInstrumentationModel;
3131
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalHttpInstrumentationModel;
3232
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalHttpServerInstrumentationModel;
33+
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalInstrumentationModel;
3334
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLanguageSpecificInstrumentationModel;
3435
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLanguageSpecificInstrumentationPropertyModel;
3536
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLoggerConfigModel;
@@ -55,7 +56,6 @@
5556
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.GrpcTlsModel;
5657
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.HttpTlsModel;
5758
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.IncludeExcludeModel;
58-
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.InstrumentationModel;
5959
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.JaegerPropagatorModel;
6060
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.LogRecordExporterModel;
6161
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.LogRecordLimitsModel;
@@ -674,8 +674,8 @@ void parse_KitchenSinkExampleFile() throws IOException {
674674
// end MeterProvider config
675675

676676
// start instrumentation config
677-
InstrumentationModel instrumentation =
678-
new InstrumentationModel()
677+
ExperimentalInstrumentationModel instrumentation =
678+
new ExperimentalInstrumentationModel()
679679
.withGeneral(
680680
new ExperimentalGeneralInstrumentationModel()
681681
.withPeer(
@@ -830,7 +830,8 @@ void parse_KitchenSinkExampleFile() throws IOException {
830830
assertThat(configMeterProvider).isEqualTo(meterProvider);
831831

832832
// Instrumentation config
833-
InstrumentationModel configInstrumentation = config.getInstrumentationDevelopment();
833+
ExperimentalInstrumentationModel configInstrumentation =
834+
config.getInstrumentationDevelopment();
834835
assertThat(configInstrumentation).isEqualTo(instrumentation);
835836

836837
// All configuration

0 commit comments

Comments
 (0)