Skip to content

Commit 0d7ab38

Browse files
committed
remove code and add test
1 parent 2b70311 commit 0d7ab38

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/state/EmptyMetricStorage.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ public void recordLong(long value, Attributes attributes, Context context) {}
4040
@Override
4141
public void recordDouble(double value, Attributes attributes, Context context) {}
4242

43-
@Override
44-
public void remove(Attributes attributes, Context context) {}
45-
4643
@Override
4744
public boolean isEnabled() {
4845
return false;

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/state/WriteableMetricStorage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public interface WriteableMetricStorage {
2424
void recordDouble(double value, Attributes attributes, Context context);
2525

2626
/** Remove a measurement. */
27-
void remove(Attributes attributes, Context context);
27+
default void remove(Attributes attributes, Context context) {}
2828

2929
/**
3030
* Returns {@code true} if the storage is actively recording measurements, and {@code false}

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/state/MetricStorageRegistryTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,6 @@ public void recordLong(long value, Attributes attributes, Context context) {}
115115
@Override
116116
public void recordDouble(double value, Attributes attributes, Context context) {}
117117

118-
@Override
119-
public void remove(Attributes attributes, Context context) {}
120-
121118
@Override
122119
public boolean isEnabled() {
123120
return true;

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/state/SynchronousMetricStorageTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -923,6 +923,20 @@ void enabledThenDisable_recordAndCollect(MemoryMode memoryMode) {
923923
storage.recordDouble(10d, Attributes.empty(), Context.current());
924924

925925
assertThat(storage.collect(RESOURCE, INSTRUMENTATION_SCOPE_INFO, 0, 10).isEmpty()).isTrue();
926+
927+
storage.remove(Attributes.empty(), Context.current());
928+
929+
storage.setEnabled(true);
930+
931+
storage.recordDouble(10d, Attributes.empty(), Context.current());
932+
933+
storage.setEnabled(false);
934+
935+
storage.remove(Attributes.empty(), Context.current());
936+
937+
storage.setEnabled(true);
938+
939+
assertThat(storage.collect(RESOURCE, INSTRUMENTATION_SCOPE_INFO, 0, 10).isEmpty()).isFalse();
926940
}
927941

928942
@ParameterizedTest

0 commit comments

Comments
 (0)