Skip to content

Commit 1a3fefb

Browse files
authored
Rename MeasureBatchRecorder to BatchRecorder to allow other types to be recorded. (#675)
* Rename MeasureBatchRecorder to BatchRecorder to allow other types to be recorded. Signed-off-by: Bogdan Drutu <[email protected]> * ./gradlew goJF Signed-off-by: Bogdan Drutu <[email protected]>
1 parent ffafe25 commit 1a3fefb

File tree

6 files changed

+17
-17
lines changed

6 files changed

+17
-17
lines changed

api/src/main/java/io/opentelemetry/metrics/MeasureBatchRecorder.java renamed to api/src/main/java/io/opentelemetry/metrics/BatchRecorder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
import javax.annotation.concurrent.ThreadSafe;
2020

2121
/**
22-
* Util class that can be use to atomically record measurements associated with a set of Measures.
22+
* Util class that can be use to atomically record measurements associated with a set of Metrics.
2323
*
2424
* <p>This class is equivalent with individually calling record on every Measure, but has the
2525
* advantage that all these operations are recorded atomically and it is more efficient.
2626
*/
2727
@ThreadSafe
28-
public interface MeasureBatchRecorder {
28+
public interface BatchRecorder {
2929
/**
3030
* Associates the {@link MeasureLong} with the given value. Subsequent updates to the same {@link
3131
* MeasureLong} will overwrite the previous value.
@@ -36,7 +36,7 @@ public interface MeasureBatchRecorder {
3636
* @throws IllegalArgumentException if value is negative.
3737
* @since 0.1.0
3838
*/
39-
MeasureBatchRecorder put(MeasureLong measure, long value);
39+
BatchRecorder put(MeasureLong measure, long value);
4040

4141
/**
4242
* Associates the {@link MeasureDouble} with the given value. Subsequent updates to the same
@@ -48,7 +48,7 @@ public interface MeasureBatchRecorder {
4848
* @throws IllegalArgumentException if value is negative.
4949
* @since 0.1.0
5050
*/
51-
MeasureBatchRecorder put(MeasureDouble measure, double value);
51+
BatchRecorder put(MeasureDouble measure, double value);
5252

5353
/**
5454
* Records all of the measures at the same time.

api/src/main/java/io/opentelemetry/metrics/DefaultMeter.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ public ObserverLong.Builder observerLongBuilder(String name) {
119119
}
120120

121121
@Override
122-
public MeasureBatchRecorder newMeasureBatchRecorder() {
123-
return new NoopMeasureBatchRecorder();
122+
public BatchRecorder newMeasureBatchRecorder() {
123+
return new NoopBatchRecorder();
124124
}
125125

126126
/** No-op implementations of GaugeLong class. */
@@ -536,18 +536,18 @@ public ObserverLong build() {
536536
}
537537
}
538538

539-
private static final class NoopMeasureBatchRecorder implements MeasureBatchRecorder {
540-
private NoopMeasureBatchRecorder() {}
539+
private static final class NoopBatchRecorder implements BatchRecorder {
540+
private NoopBatchRecorder() {}
541541

542542
@Override
543-
public MeasureBatchRecorder put(MeasureLong measure, long value) {
543+
public BatchRecorder put(MeasureLong measure, long value) {
544544
Utils.checkNotNull(measure, "measure");
545545
Utils.checkArgument(value >= 0, "Unsupported negative values.");
546546
return this;
547547
}
548548

549549
@Override
550-
public MeasureBatchRecorder put(MeasureDouble measure, double value) {
550+
public BatchRecorder put(MeasureDouble measure, double value) {
551551
Utils.checkNotNull(measure, "measure");
552552
Utils.checkArgument(value >= 0.0, "Unsupported negative values.");
553553
return this;

api/src/main/java/io/opentelemetry/metrics/Meter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,5 +224,5 @@ public interface Meter {
224224
* measurements associated with different Measures.
225225
* @since 0.1.0
226226
*/
227-
MeasureBatchRecorder newMeasureBatchRecorder();
227+
BatchRecorder newMeasureBatchRecorder();
228228
}

api/src/test/java/io/opentelemetry/OpenTelemetryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@
2626
import io.opentelemetry.distributedcontext.DistributedContext;
2727
import io.opentelemetry.distributedcontext.DistributedContextManager;
2828
import io.opentelemetry.distributedcontext.spi.DistributedContextManagerProvider;
29+
import io.opentelemetry.metrics.BatchRecorder;
2930
import io.opentelemetry.metrics.CounterDouble;
3031
import io.opentelemetry.metrics.CounterLong;
3132
import io.opentelemetry.metrics.DefaultMeterFactory;
3233
import io.opentelemetry.metrics.GaugeDouble;
3334
import io.opentelemetry.metrics.GaugeLong;
34-
import io.opentelemetry.metrics.MeasureBatchRecorder;
3535
import io.opentelemetry.metrics.MeasureDouble;
3636
import io.opentelemetry.metrics.MeasureLong;
3737
import io.opentelemetry.metrics.Meter;
@@ -360,7 +360,7 @@ public ObserverLong.Builder observerLongBuilder(String name) {
360360

361361
@Nullable
362362
@Override
363-
public MeasureBatchRecorder newMeasureBatchRecorder() {
363+
public BatchRecorder newMeasureBatchRecorder() {
364364
return null;
365365
}
366366

api/src/test/java/io/opentelemetry/metrics/MeasureBatchRecorderTest.java renamed to api/src/test/java/io/opentelemetry/metrics/BatchRecorderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
import org.junit.runner.RunWith;
2323
import org.junit.runners.JUnit4;
2424

25-
/** Tests for {@link MeasureBatchRecorder}. */
25+
/** Tests for {@link BatchRecorder}. */
2626
@RunWith(JUnit4.class)
27-
public class MeasureBatchRecorderTest {
27+
public class BatchRecorderTest {
2828
private static final Meter meter = DefaultMeter.getInstance();
2929
private static final MeasureLong measureLong = meter.measureLongBuilder("measure_long").build();
3030
private static final MeasureDouble measureDouble =

sdk/src/main/java/io/opentelemetry/sdk/metrics/MeterSdk.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616

1717
package io.opentelemetry.sdk.metrics;
1818

19+
import io.opentelemetry.metrics.BatchRecorder;
1920
import io.opentelemetry.metrics.CounterDouble;
2021
import io.opentelemetry.metrics.CounterLong;
2122
import io.opentelemetry.metrics.GaugeDouble;
2223
import io.opentelemetry.metrics.GaugeLong;
23-
import io.opentelemetry.metrics.MeasureBatchRecorder;
2424
import io.opentelemetry.metrics.MeasureDouble;
2525
import io.opentelemetry.metrics.MeasureLong;
2626
import io.opentelemetry.metrics.Meter;
@@ -71,7 +71,7 @@ public ObserverLong.Builder observerLongBuilder(String name) {
7171
}
7272

7373
@Override
74-
public MeasureBatchRecorder newMeasureBatchRecorder() {
74+
public BatchRecorder newMeasureBatchRecorder() {
7575
throw new UnsupportedOperationException("to be implemented");
7676
}
7777
}

0 commit comments

Comments
 (0)