Skip to content

Commit 1f8ee51

Browse files
authored
Remove support for deprecated otel.experimental.resource.disabled.keys (#6931)
1 parent e61e19a commit 1f8ee51

File tree

2 files changed

+0
-34
lines changed

2 files changed

+0
-34
lines changed

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ResourceConfiguration.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.util.Map;
2626
import java.util.Set;
2727
import java.util.function.BiFunction;
28-
import java.util.logging.Logger;
2928

3029
/**
3130
* Auto-configuration for the OpenTelemetry {@link Resource}.
@@ -34,15 +33,11 @@
3433
*/
3534
public final class ResourceConfiguration {
3635

37-
private static final Logger logger = Logger.getLogger(ResourceConfiguration.class.getName());
38-
3936
private static final AttributeKey<String> SERVICE_NAME = AttributeKey.stringKey("service.name");
4037

4138
// Visible for testing
4239
static final String ATTRIBUTE_PROPERTY = "otel.resource.attributes";
4340
static final String SERVICE_NAME_PROPERTY = "otel.service.name";
44-
static final String EXPERIMENTAL_DISABLED_ATTRIBUTE_KEYS =
45-
"otel.experimental.resource.disabled.keys";
4641
static final String DISABLED_ATTRIBUTE_KEYS = "otel.resource.disabled.keys";
4742

4843
/**
@@ -120,14 +115,6 @@ static Resource configureResource(
120115
// visible for testing
121116
static Resource filterAttributes(Resource resource, ConfigProperties configProperties) {
122117
List<String> disabledAttibuteKeys = configProperties.getList(DISABLED_ATTRIBUTE_KEYS);
123-
// TODO: Remove this once the deprecated property is removed.
124-
if (disabledAttibuteKeys.isEmpty()) {
125-
disabledAttibuteKeys = configProperties.getList(EXPERIMENTAL_DISABLED_ATTRIBUTE_KEYS);
126-
if (!disabledAttibuteKeys.isEmpty()) {
127-
logger.warning(
128-
"otel.experimental.resource.disabled.keys is deprecated and will be removed after 1.45.0 release. Please use otel.resource.disabled.keys instead.");
129-
}
130-
}
131118
Set<String> disabledKeys = new HashSet<>(disabledAttibuteKeys);
132119

133120
ResourceBuilder builder =

sdk-extensions/autoconfigure/src/test/java/io/opentelemetry/sdk/autoconfigure/ResourceConfigurationTest.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -46,27 +46,6 @@ void customConfigResourceWithDisabledKeys() {
4646
.build());
4747
}
4848

49-
@Test
50-
void customConfigResourceWithExperimentalDisabledKeys() {
51-
Map<String, String> props = new HashMap<>();
52-
props.put("otel.service.name", "test-service");
53-
props.put(
54-
"otel.resource.attributes", "food=cheesecake,drink=juice,animal= ,color=,shape=square");
55-
props.put("otel.experimental.resource.disabled-keys", "drink");
56-
57-
assertThat(
58-
ResourceConfiguration.configureResource(
59-
DefaultConfigProperties.create(props),
60-
SpiHelper.create(ResourceConfigurationTest.class.getClassLoader()),
61-
(r, c) -> r))
62-
.isEqualTo(
63-
Resource.getDefault().toBuilder()
64-
.put(stringKey("service.name"), "test-service")
65-
.put("food", "cheesecake")
66-
.put("shape", "square")
67-
.build());
68-
}
69-
7049
@Test
7150
void createEnvironmentResource_Empty() {
7251
Attributes attributes = ResourceConfiguration.createEnvironmentResource().getAttributes();

0 commit comments

Comments
 (0)