Skip to content

Commit 215f832

Browse files
committed
return extended otel sdk
1 parent 10d7c47 commit 215f832

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationFactoryTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import io.opentelemetry.extension.trace.propagation.JaegerPropagator;
2323
import io.opentelemetry.extension.trace.propagation.OtTracePropagator;
2424
import io.opentelemetry.internal.testing.CleanupExtension;
25-
import io.opentelemetry.sdk.OpenTelemetrySdk;
2625
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
2726
import io.opentelemetry.sdk.extension.incubator.ExtendedOpenTelemetrySdk;
2827
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.AlwaysOnSamplerModel;
@@ -115,22 +114,26 @@ private static Stream<Arguments> fileFormatArgs() {
115114
@Test
116115
void create_Defaults() {
117116
List<Closeable> closeables = new ArrayList<>();
118-
OpenTelemetrySdk expectedSdk = OpenTelemetrySdk.builder().build();
117+
OpenTelemetryConfigurationModel model =
118+
new OpenTelemetryConfigurationModel().withFileFormat("1.0-rc.1");
119+
ExtendedOpenTelemetrySdk expectedSdk =
120+
ExtendedOpenTelemetrySdk.builder()
121+
.setConfigProvider(SdkConfigProvider.create(model))
122+
.build();
119123
cleanup.addCloseable(expectedSdk);
120124

121125
ExtendedOpenTelemetrySdk sdk =
122-
OpenTelemetryConfigurationFactory.getInstance()
123-
.create(new OpenTelemetryConfigurationModel().withFileFormat("1.0-rc.1"), context);
126+
OpenTelemetryConfigurationFactory.getInstance().create(model, context);
124127
cleanup.addCloseable(sdk);
125128
cleanup.addCloseables(closeables);
126129

127-
assertThat(sdk.toString()).isEqualTo(expectedSdk.toString());
130+
assertThat(sdk).hasToString(expectedSdk.toString());
128131
}
129132

130133
@Test
131134
void create_Disabled() {
132135
List<Closeable> closeables = new ArrayList<>();
133-
OpenTelemetrySdk expectedSdk = OpenTelemetrySdk.builder().build();
136+
ExtendedOpenTelemetrySdk expectedSdk = ExtendedOpenTelemetrySdk.builder().build();
134137
cleanup.addCloseable(expectedSdk);
135138

136139
ExtendedOpenTelemetrySdk sdk =

0 commit comments

Comments
 (0)