Skip to content

Commit 2989362

Browse files
committed
Reduce test visibility, close exporters
1 parent 48a0ab4 commit 2989362

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

exporters/otlp/all/src/test/java/io/opentelemetry/exporter/otlp/http/metrics/OtlpHttpMetricExporterBuilderTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313
import org.junit.jupiter.api.Test;
1414
import org.mockito.Mockito;
1515

16-
public class OtlpHttpMetricExporterBuilderTest {
16+
class OtlpHttpMetricExporterBuilderTest {
1717

1818
@Test
19-
public void verifyToBuilderPreservesSettings() {
19+
void verifyToBuilderPreservesSettings() {
2020
AggregationTemporalitySelector temporalitySelector =
2121
Mockito.mock(AggregationTemporalitySelector.class);
2222
DefaultAggregationSelector defaultAggregationSelector =
@@ -34,5 +34,8 @@ public void verifyToBuilderPreservesSettings() {
3434
assertThat(copy.getMemoryMode()).isEqualTo(MemoryMode.IMMUTABLE_DATA);
3535
assertThat(copy.aggregationTemporalitySelector).isSameAs(temporalitySelector);
3636
assertThat(copy.defaultAggregationSelector).isSameAs(defaultAggregationSelector);
37+
38+
original.close();
39+
copy.close();
3740
}
3841
}

exporters/otlp/all/src/test/java/io/opentelemetry/exporter/otlp/metrics/OtlpGrpcMetricExporterBuilderTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313
import org.junit.jupiter.api.Test;
1414
import org.mockito.Mockito;
1515

16-
public class OtlpGrpcMetricExporterBuilderTest {
16+
class OtlpGrpcMetricExporterBuilderTest {
1717

1818
@Test
19-
public void verifyToBuilderPreservesSettings() {
19+
void verifyToBuilderPreservesSettings() {
2020
AggregationTemporalitySelector temporalitySelector =
2121
Mockito.mock(AggregationTemporalitySelector.class);
2222
DefaultAggregationSelector defaultAggregationSelector =
@@ -34,5 +34,8 @@ public void verifyToBuilderPreservesSettings() {
3434
assertThat(copy.getMemoryMode()).isEqualTo(MemoryMode.IMMUTABLE_DATA);
3535
assertThat(copy.aggregationTemporalitySelector).isSameAs(temporalitySelector);
3636
assertThat(copy.defaultAggregationSelector).isSameAs(defaultAggregationSelector);
37+
38+
original.close();
39+
copy.close();
3740
}
3841
}

0 commit comments

Comments
 (0)