Skip to content

Commit 3672a2d

Browse files
committed
Update to rc.3
1 parent 10b06bd commit 3672a2d

File tree

3 files changed

+7
-29
lines changed

3 files changed

+7
-29
lines changed

sdk-extensions/incubator/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ dependencies {
5858
// 6. deleteJs2pTmp - delete tmp directory
5959
// ... proceed with normal sourcesJar, compileJava, etc
6060

61-
val configurationTag = "1.0.0-rc.1"
62-
val configurationRef = "447ff81a6dc566243813e6e45e378adf9a5b0bd7" // Replace with commit SHA to point to experiment with a specific commit
61+
val configurationTag = "1.0.0-rc.3"
62+
val configurationRef = "refs/tags/v$configurationTag" // Replace with commit SHA to point to experiment with a specific commit
6363
val configurationRepoZip = "https://github.com/open-telemetry/opentelemetry-configuration/archive/$configurationRef.zip"
6464
val buildDirectory = layout.buildDirectory.asFile.get()
6565

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigurationParseTest.java

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@
9292
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.SimpleLogRecordProcessorModel;
9393
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.SimpleSpanProcessorModel;
9494
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.SpanExporterModel;
95-
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.SpanExporterPropertyModel;
9695
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.SpanKind;
9796
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.SpanLimitsModel;
9897
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.SpanProcessorModel;
@@ -135,7 +134,7 @@ void parse_BadInputStream() {
135134
void parse_KitchenSinkExampleFile() throws IOException {
136135
OpenTelemetryConfigurationModel expected = new OpenTelemetryConfigurationModel();
137136

138-
expected.withFileFormat("1.0-rc.2");
137+
expected.withFileFormat("1.0-rc.3");
139138
expected.withDisabled(false);
140139
expected.withLogLevel(OpenTelemetryConfigurationModel.SeverityNumber.INFO);
141140

@@ -379,30 +378,13 @@ void parse_KitchenSinkExampleFile() throws IOException {
379378
new ExperimentalOtlpFileExporterModel()
380379
.withOutputStream("stdout"))));
381380
SpanProcessorModel spanProcessor5 =
382-
new SpanProcessorModel()
383-
.withBatch(
384-
new BatchSpanProcessorModel()
385-
.withExporter(
386-
new SpanExporterModel()
387-
.withAdditionalProperty(
388-
"zipkin",
389-
new SpanExporterPropertyModel()
390-
.withAdditionalProperty(
391-
"endpoint", "http://localhost:9411/api/v2/spans")
392-
.withAdditionalProperty("timeout", 10_000))));
393-
SpanProcessorModel spanProcessor6 =
394381
new SpanProcessorModel()
395382
.withSimple(
396383
new SimpleSpanProcessorModel()
397384
.withExporter(new SpanExporterModel().withConsole(new ConsoleExporterModel())));
398385
tracerProvider.withProcessors(
399386
Arrays.asList(
400-
spanProcessor1,
401-
spanProcessor2,
402-
spanProcessor3,
403-
spanProcessor4,
404-
spanProcessor5,
405-
spanProcessor6));
387+
spanProcessor1, spanProcessor2, spanProcessor3, spanProcessor4, spanProcessor5));
406388

407389
expected.withTracerProvider(tracerProvider);
408390
// end TracerProvider config
@@ -840,7 +822,7 @@ void parse_KitchenSinkExampleFile() throws IOException {
840822
OpenTelemetryConfigurationModel config = DeclarativeConfiguration.parse(configExampleFile);
841823

842824
// General config
843-
assertThat(config.getFileFormat()).isEqualTo("1.0-rc.2");
825+
assertThat(config.getFileFormat()).isEqualTo("1.0-rc.3");
844826
assertThat(config.getResource()).isEqualTo(resource);
845827
assertThat(config.getAttributeLimits()).isEqualTo(attributeLimits);
846828
assertThat(config.getPropagator()).isEqualTo(propagator);
@@ -854,12 +836,7 @@ void parse_KitchenSinkExampleFile() throws IOException {
854836
assertThat(configTracerProvider.getProcessors())
855837
.isEqualTo(
856838
Arrays.asList(
857-
spanProcessor1,
858-
spanProcessor2,
859-
spanProcessor3,
860-
spanProcessor4,
861-
spanProcessor5,
862-
spanProcessor6));
839+
spanProcessor1, spanProcessor2, spanProcessor3, spanProcessor4, spanProcessor5));
863840
assertThat(configTracerProvider).isEqualTo(tracerProvider);
864841

865842
// LoggerProvider config

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationFactoryTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ private static Stream<Arguments> fileFormatArgs() {
114114
Arguments.of("0.4", true),
115115
Arguments.of("1.0-rc.1", true),
116116
Arguments.of("1.0-rc.2", true),
117+
Arguments.of("1.0-rc.3", true),
117118
Arguments.of("1.0", true));
118119
}
119120

0 commit comments

Comments
 (0)