Skip to content

Commit 37e35b2

Browse files
Update errorProneVersion to v2.31.0 (#6642)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jack Berg <[email protected]>
1 parent 365fe8a commit 37e35b2

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

dependencyManagement/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ val DEPENDENCY_BOMS = listOf(
2525
)
2626

2727
val autoValueVersion = "1.11.0"
28-
val errorProneVersion = "2.29.2"
28+
val errorProneVersion = "2.31.0"
2929
val jmhVersion = "1.37"
3030
// Mockito 5.x.x requires Java 11 https://github.com/mockito/mockito/releases/tag/v5.0.0
3131
val mockitoVersion = "4.11.0"

sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/RateLimitingSampler.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.text.DecimalFormat;
2222
import java.text.DecimalFormatSymbols;
2323
import java.util.List;
24+
import java.util.Locale;
2425

2526
/**
2627
* {@link RateLimitingSampler} sampler uses a leaky bucket rate limiter to ensure that traces are
@@ -73,7 +74,7 @@ public String toString() {
7374
}
7475

7576
private static String decimalFormat(double value) {
76-
DecimalFormatSymbols decimalFormatSymbols = DecimalFormatSymbols.getInstance();
77+
DecimalFormatSymbols decimalFormatSymbols = DecimalFormatSymbols.getInstance(Locale.ROOT);
7778
decimalFormatSymbols.setDecimalSeparator('.');
7879

7980
DecimalFormat decimalFormat = new DecimalFormat("0.00", decimalFormatSymbols);

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/debug/StackTraceSourceInfo.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
package io.opentelemetry.sdk.metrics.internal.debug;
77

8+
import java.util.Locale;
9+
810
/** Diagnostic information derived from stack traces. */
911
final class StackTraceSourceInfo implements SourceInfo {
1012

@@ -19,7 +21,7 @@ public String shortDebugString() {
1921
if (stackTraceElements.length > 0) {
2022
for (StackTraceElement e : stackTraceElements) {
2123
if (isInterestingStackTrace(e)) {
22-
return String.format("%s:%d", e.getFileName(), e.getLineNumber());
24+
return String.format(Locale.ROOT, "%s:%d", e.getFileName(), e.getLineNumber());
2325
}
2426
}
2527
}

sdk/trace/src/main/java/io/opentelemetry/sdk/trace/samplers/TraceIdRatioBasedSampler.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import java.text.DecimalFormat;
1414
import java.text.DecimalFormatSymbols;
1515
import java.util.List;
16+
import java.util.Locale;
1617
import javax.annotation.Nullable;
1718
import javax.annotation.concurrent.Immutable;
1819

@@ -112,7 +113,7 @@ private static long getTraceIdRandomPart(String traceId) {
112113
}
113114

114115
private static String decimalFormat(double value) {
115-
DecimalFormatSymbols decimalFormatSymbols = DecimalFormatSymbols.getInstance();
116+
DecimalFormatSymbols decimalFormatSymbols = DecimalFormatSymbols.getInstance(Locale.ROOT);
116117
decimalFormatSymbols.setDecimalSeparator('.');
117118

118119
DecimalFormat decimalFormat = new DecimalFormat("0.000000", decimalFormatSymbols);

0 commit comments

Comments
 (0)