Skip to content

Commit 3a7a05a

Browse files
committed
fix architecture test
1 parent 176c981 commit 3a7a05a

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/ExtendedOpenTelemetrySdk.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
import io.opentelemetry.api.incubator.ExtendedOpenTelemetry;
99
import io.opentelemetry.api.incubator.config.ConfigProvider;
1010
import io.opentelemetry.sdk.OpenTelemetrySdk;
11-
import io.opentelemetry.sdk.WithShutdown;
11+
import java.io.Closeable;
1212
import java.lang.reflect.Field;
1313
import javax.annotation.Nullable;
1414

1515
/** A new interface for creating OpenTelemetrySdk that supports getting {@link ConfigProvider}. */
16-
public interface ExtendedOpenTelemetrySdk extends ExtendedOpenTelemetry, WithShutdown {
16+
public interface ExtendedOpenTelemetrySdk extends ExtendedOpenTelemetry, Closeable {
1717
/** Returns a builder for {@link ExtendedOpenTelemetrySdk}. */
1818
static ExtendedOpenTelemetrySdkBuilder builder() {
1919
return new ExtendedOpenTelemetrySdkBuilder();

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/ObfuscatedExtendedOpenTelemetrySdk.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import io.opentelemetry.sdk.trace.SdkTracerProvider;
2121
import java.util.ArrayList;
2222
import java.util.List;
23+
import java.util.concurrent.TimeUnit;
2324
import java.util.concurrent.atomic.AtomicBoolean;
2425
import java.util.logging.Logger;
2526
import javax.annotation.concurrent.ThreadSafe;
@@ -49,7 +50,6 @@ public ObfuscatedExtendedOpenTelemetrySdk(
4950
this.propagators = propagators;
5051
}
5152

52-
@Override
5353
public CompletableResultCode shutdown() {
5454
if (!isShutdown.compareAndSet(false, true)) {
5555
LOGGER.info("Multiple shutdown calls");
@@ -62,6 +62,11 @@ public CompletableResultCode shutdown() {
6262
return CompletableResultCode.ofAll(results);
6363
}
6464

65+
@Override
66+
public void close() {
67+
shutdown().join(10, TimeUnit.SECONDS);
68+
}
69+
6570
@Override
6671
public ConfigProvider getConfigProvider() {
6772
return configProvider;

sdk/all/src/main/java/io/opentelemetry/sdk/OpenTelemetrySdk.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
/** The SDK implementation of {@link OpenTelemetry}. */
3131
@ThreadSafe
32-
public final class OpenTelemetrySdk implements OpenTelemetry, Closeable, WithShutdown {
32+
public final class OpenTelemetrySdk implements OpenTelemetry, Closeable {
3333

3434
private static final Logger LOGGER = Logger.getLogger(OpenTelemetrySdk.class.getName());
3535

@@ -100,7 +100,12 @@ public ContextPropagators getPropagators() {
100100
return propagators;
101101
}
102102

103-
@Override
103+
/**
104+
* Shutdown the SDK. Calls {@link SdkTracerProvider#shutdown()}, {@link
105+
* SdkMeterProvider#shutdown()}, and {@link SdkLoggerProvider#shutdown()}.
106+
*
107+
* @return a {@link CompletableResultCode} which completes when all providers are shutdown
108+
*/
104109
public CompletableResultCode shutdown() {
105110
if (extendedOpenTelemetrySdk != null) {
106111
// If an ExtendedOpenTelemetrySdk is present, we delegate the shutdown to it.

0 commit comments

Comments
 (0)