Skip to content

Commit 3d792ff

Browse files
committed
fix test
1 parent 920f158 commit 3d792ff

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

sdk-extensions/autoconfigure/src/testIncubating/java/io/opentelemetry/sdk/autoconfigure/DeclarativeConfigurationTest.java

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,11 @@
3333
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
3434
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException;
3535
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
36+
import io.opentelemetry.sdk.extension.incubator.ExtendedOpenTelemetrySdk;
37+
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
38+
import io.opentelemetry.sdk.extension.incubator.fileconfig.SdkConfigProvider;
39+
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
3640
import io.opentelemetry.sdk.resources.Resource;
37-
import io.opentelemetry.sdk.trace.SdkTracerProvider;
3841
import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor;
3942
import java.io.IOException;
4043
import java.nio.charset.StandardCharsets;
@@ -114,19 +117,22 @@ void configFile_fileNotFound() {
114117
}
115118

116119
@Test
117-
void configFile_Valid() {
120+
void configFile_Valid() throws IOException {
118121
ConfigProperties config =
119122
DefaultConfigProperties.createFromMap(
120123
Collections.singletonMap("otel.experimental.config.file", configFilePath.toString()));
124+
OpenTelemetryConfigurationModel model =
125+
DeclarativeConfiguration.parse(Files.newInputStream(configFilePath.toFile().toPath()));
121126
OpenTelemetrySdk expectedSdk =
122-
OpenTelemetrySdk.builder()
123-
.setTracerProvider(
124-
SdkTracerProvider.builder()
125-
.setResource(
126-
Resource.getDefault().toBuilder().put("service.name", "test").build())
127-
.addSpanProcessor(SimpleSpanProcessor.create(LoggingSpanExporter.create()))
128-
.build())
127+
ExtendedOpenTelemetrySdk.builder()
128+
.setConfigProvider(SdkConfigProvider.create(model))
129+
.withTracerProvider(
130+
b ->
131+
b.setResource(
132+
Resource.getDefault().toBuilder().put("service.name", "test").build())
133+
.addSpanProcessor(SimpleSpanProcessor.create(LoggingSpanExporter.create())))
129134
.build();
135+
130136
cleanup.addCloseable(expectedSdk);
131137
AutoConfiguredOpenTelemetrySdkBuilder builder = spy(AutoConfiguredOpenTelemetrySdk.builder());
132138
Thread thread = new Thread();

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationFactoryTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ void create_FileFormat(String fileFormat, boolean isValid) {
9090
assertThatThrownBy(
9191
() -> OpenTelemetryConfigurationFactory.getInstance().create(model, context))
9292
.isInstanceOf(DeclarativeConfigException.class)
93-
.hasMessageMatching(
94-
"Unsupported file format '.+'\\. Supported formats include 0\\.4, 1\\.0\\*");
93+
.hasMessage("Unsupported file format. Supported formats include 0.4, 1.0*");
9594
}
9695
}
9796

0 commit comments

Comments
 (0)