Delete unused Measurement and related code

Author: jack-berg

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/aggregator/Aggregator.java

@@ -13,7 +13,6 @@
 import io.opentelemetry.sdk.metrics.data.MetricDataType;
 import io.opentelemetry.sdk.metrics.data.PointData;
 import io.opentelemetry.sdk.metrics.internal.descriptor.MetricDescriptor;
-import io.opentelemetry.sdk.metrics.internal.state.Measurement;
 import io.opentelemetry.sdk.resources.Resource;
 import java.util.Collection;
 import javax.annotation.concurrent.Immutable;
@@ -68,24 +67,6 @@ default void diffInPlace(T previousCumulativeReusable, T currentCumulative) {
     throw new UnsupportedOperationException("This aggregator does not support diffInPlace.");
   }
 
-  /**
-   * Return a new point representing the measurement.
-   *
-   * <p>Aggregators MUST implement diff if it can be used with asynchronous instruments.
-   */
-  default T toPoint(Measurement measurement) {
-    throw new UnsupportedOperationException("This aggregator does not support toPoint.");
-  }
-
-  /**
-   * Resets {@code reusablePoint} to represent the {@code measurement}.
-   *
-   * <p>Aggregators MUST implement diff if it can be used with asynchronous instruments.
-   */
-  default void toPoint(Measurement measurement, T reusablePoint) {
-    throw new UnsupportedOperationException("This aggregator does not support toPoint.");
-  }
-
   /** Creates a new reusable point. */
   default T createReusablePoint() {
     throw new UnsupportedOperationException(

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/aggregator/DoubleLastValueAggregator.java

@@ -18,7 +18,6 @@
 import io.opentelemetry.sdk.metrics.internal.data.MutableDoublePointData;
 import io.opentelemetry.sdk.metrics.internal.descriptor.MetricDescriptor;
 import io.opentelemetry.sdk.metrics.internal.exemplar.ExemplarReservoir;
-import io.opentelemetry.sdk.metrics.internal.state.Measurement;
 import io.opentelemetry.sdk.resources.Resource;
 import java.util.Collection;
 import java.util.List;
@@ -67,25 +66,6 @@ public void diffInPlace(DoublePointData previousReusable, DoublePointData curren
     ((MutableDoublePointData) previousReusable).set(current);
   }
 
-  @Override
-  public DoublePointData toPoint(Measurement measurement) {
-    return ImmutableDoublePointData.create(
-        measurement.startEpochNanos(),
-        measurement.epochNanos(),
-        measurement.attributes(),
-        measurement.doubleValue());
-  }
-
-  @Override
-  public void toPoint(Measurement measurement, DoublePointData reusablePoint) {
-    ((MutableDoublePointData) reusablePoint)
-        .set(
-            measurement.startEpochNanos(),
-            measurement.epochNanos(),
-            measurement.attributes(),
-            measurement.doubleValue());
-  }
-
   @Override
   public DoublePointData createReusablePoint() {
     return new MutableDoublePointData();

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/aggregator/DoubleSumAggregator.java

@@ -21,7 +21,6 @@
 import io.opentelemetry.sdk.metrics.internal.descriptor.InstrumentDescriptor;
 import io.opentelemetry.sdk.metrics.internal.descriptor.MetricDescriptor;
 import io.opentelemetry.sdk.metrics.internal.exemplar.ExemplarReservoir;
-import io.opentelemetry.sdk.metrics.internal.state.Measurement;
 import io.opentelemetry.sdk.resources.Resource;
 import java.util.Collection;
 import java.util.List;
@@ -82,25 +81,6 @@ public void diffInPlace(DoublePointData previousReusablePoint, DoublePointData c
             currentPoint.getExemplars());
   }
 
-  @Override
-  public DoublePointData toPoint(Measurement measurement) {
-    return ImmutableDoublePointData.create(
-        measurement.startEpochNanos(),
-        measurement.epochNanos(),
-        measurement.attributes(),
-        measurement.doubleValue());
-  }
-
-  @Override
-  public void toPoint(Measurement measurement, DoublePointData reusablePoint) {
-    ((MutableDoublePointData) reusablePoint)
-        .set(
-            measurement.startEpochNanos(),
-            measurement.epochNanos(),
-            measurement.attributes(),
-            measurement.doubleValue());
-  }
-
   @Override
   public DoublePointData createReusablePoint() {
     return new MutableDoublePointData();

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/aggregator/LongLastValueAggregator.java

@@ -18,7 +18,6 @@
 import io.opentelemetry.sdk.metrics.internal.data.MutableLongPointData;
 import io.opentelemetry.sdk.metrics.internal.descriptor.MetricDescriptor;
 import io.opentelemetry.sdk.metrics.internal.exemplar.ExemplarReservoir;
-import io.opentelemetry.sdk.metrics.internal.state.Measurement;
 import io.opentelemetry.sdk.resources.Resource;
 import java.util.Collection;
 import java.util.List;
@@ -63,25 +62,6 @@ public void diffInPlace(LongPointData previousReusablePoint, LongPointData curre
     ((MutableLongPointData) previousReusablePoint).set(currentPoint);
   }
 
-  @Override
-  public LongPointData toPoint(Measurement measurement) {
-    return ImmutableLongPointData.create(
-        measurement.startEpochNanos(),
-        measurement.epochNanos(),
-        measurement.attributes(),
-        measurement.longValue());
-  }
-
-  @Override
-  public void toPoint(Measurement measurement, LongPointData reusablePoint) {
-    ((MutableLongPointData) reusablePoint)
-        .set(
-            measurement.startEpochNanos(),
-            measurement.epochNanos(),
-            measurement.attributes(),
-            measurement.longValue());
-  }
-
   @Override
   public LongPointData createReusablePoint() {
     return new MutableLongPointData();

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/aggregator/LongSumAggregator.java

@@ -21,7 +21,6 @@
 import io.opentelemetry.sdk.metrics.internal.descriptor.InstrumentDescriptor;
 import io.opentelemetry.sdk.metrics.internal.descriptor.MetricDescriptor;
 import io.opentelemetry.sdk.metrics.internal.exemplar.ExemplarReservoir;
-import io.opentelemetry.sdk.metrics.internal.state.Measurement;
 import io.opentelemetry.sdk.resources.Resource;
 import java.util.Collection;
 import java.util.List;
@@ -75,25 +74,6 @@ public void diffInPlace(LongPointData previousReusablePoint, LongPointData curre
             currentPoint.getExemplars());
   }
 
-  @Override
-  public LongPointData toPoint(Measurement measurement) {
-    return ImmutableLongPointData.create(
-        measurement.startEpochNanos(),
-        measurement.epochNanos(),
-        measurement.attributes(),
-        measurement.longValue());
-  }
-
-  @Override
-  public void toPoint(Measurement measurement, LongPointData reusablePoint) {
-    ((MutableLongPointData) reusablePoint)
-        .set(
-            measurement.startEpochNanos(),
-            measurement.epochNanos(),
-            measurement.attributes(),
-            measurement.longValue());
-  }
-
   @Override
   public LongPointData createReusablePoint() {
     return new MutableLongPointData();

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/state/AsynchronousMetricStorage.java

@@ -227,10 +227,7 @@ private Collection<T> collectWithDeltaAggregationTemporality() {
         (attributes, handle) -> {
           T point =
               handle.aggregateThenMaybeReset(
-                  AsynchronousMetricStorage.this.startEpochNanos,
-                  AsynchronousMetricStorage.this.epochNanos,
-                  attributes,
-                  /* reset= */ true);
+                  this.startEpochNanos, this.epochNanos, attributes, /* reset= */ true);
 
           T pointForCurrentPoints;
           if (memoryMode == REUSABLE_DATA) {