Skip to content

Commit 4d79850

Browse files
committed
pr review
1 parent 6d2bd3a commit 4d79850

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusMetricReader.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,17 @@ public class PrometheusMetricReader implements MetricReader, MultiCollector {
2828
private volatile CollectionRegistration collectionRegistration = CollectionRegistration.noop();
2929
private final Otel2PrometheusConverter converter;
3030

31+
/**
32+
* @deprecated use {@link PrometheusMetricReader#PrometheusMetricReader(OtelScopeMode, Predicate)}
33+
* instead.
34+
*/
35+
@SuppressWarnings("unused")
36+
@Deprecated
37+
public PrometheusMetricReader(
38+
boolean otelScopeEnabled, @Nullable Predicate<String> allowedResourceAttributesFilter) {
39+
this(OtelScopeMode.LABELS_AND_SCOPE_INFO, allowedResourceAttributesFilter);
40+
}
41+
3142
// TODO: refactor to public static create or builder pattern to align with project style
3243
/** See {@link Otel2PrometheusConverter#Otel2PrometheusConverter(OtelScopeMode, Predicate)}. */
3344
public PrometheusMetricReader(

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/internal/PrometheusComponentProvider.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.opentelemetry.sdk.internal.IncludeExcludePredicate;
1414
import io.opentelemetry.sdk.metrics.export.MetricReader;
1515
import java.util.List;
16-
import java.util.Objects;
1716

1817
/**
1918
* Declarative configuration SPI implementation for {@link PrometheusHttpServer}.

0 commit comments

Comments
 (0)