Skip to content

Commit 576f287

Browse files
committed
pr review
1 parent 2283eb6 commit 576f287

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

api/incubator/src/main/java/io/opentelemetry/api/incubator/config/ConfigProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public interface ConfigProvider {
4040
* @param name the name of the instrumentation
4141
* @return the {@link DeclarativeConfigProperties} for the given instrumentation name
4242
*/
43-
default DeclarativeConfigProperties getJavaInstrumentationConfig(String name) {
43+
default DeclarativeConfigProperties getInstrumentationConfig(String name) {
4444
DeclarativeConfigProperties config = getInstrumentationConfig();
4545
return config == null ? empty() : config.get("java").get(name);
4646
}

api/incubator/src/test/java/io/opentelemetry/api/incubator/ConfigProviderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ void noopEquality() {
2222
void instrumentationConfigFallback() {
2323
ConfigProvider configProvider = ConfigProvider.noop();
2424
assertThat(configProvider.getInstrumentationConfig()).isNull();
25-
assertThat(configProvider.getJavaInstrumentationConfig("servlet")).isNotNull();
25+
assertThat(configProvider.getInstrumentationConfig("servlet")).isNotNull();
2626
assertThat(configProvider.getGeneralInstrumentationConfig()).isNotNull();
2727
}
2828
}

sdk-extensions/autoconfigure/src/testIncubating/java/io/opentelemetry/sdk/autoconfigure/DeclarativeConfigurationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ void configFile_ConfigProvider() {
233233
.satisfies(exampleConfig -> assertThat(exampleConfig.getString("key")).isEqualTo("value"));
234234

235235
// shortcuts to get specific instrumentation config
236-
assertThat(globalConfigProvider.getJavaInstrumentationConfig("example").getString("key"))
236+
assertThat(globalConfigProvider.getInstrumentationConfig("example").getString("key"))
237237
.isEqualTo("value");
238238
assertThat(
239239
globalConfigProvider

0 commit comments

Comments
 (0)