Skip to content

Commit 608de71

Browse files
committed
use record class
1 parent ad30c97 commit 608de71

File tree

2 files changed

+8
-23
lines changed

2 files changed

+8
-23
lines changed

javadoc-crawler/src/main/java/io/opentelemetry/javadocs/Artifact.java

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,4 @@
55

66
package io.opentelemetry.javadocs;
77

8-
public class Artifact {
9-
private final String name;
10-
private final String version;
11-
12-
public Artifact(String name, String version) {
13-
this.name = name;
14-
this.version = version;
15-
}
16-
17-
public String getName() {
18-
return name;
19-
}
20-
21-
public String getVersion() {
22-
return version;
23-
}
24-
}
8+
public record Artifact(String name, String version) {}

javadoc-crawler/src/main/java/io/opentelemetry/javadocs/JavaDocsCrawler.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,8 @@ private static List<Artifact> convertToArtifacts(Map<?, ?> map) {
121121
HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
122122
if (response.statusCode() != 200) {
123123
logger.log(
124-
Level.SEVERE, "Unexpected response code: " + response.statusCode() + ": " + response.body());
124+
Level.SEVERE,
125+
"Unexpected response code: " + response.statusCode() + ": " + response.body());
125126
throw new IOException("Unable to pull Maven central artifacts list");
126127
}
127128
return objectMapper.readValue(response.body(), Map.class);
@@ -132,14 +133,14 @@ static List<String> crawlJavaDocs(HttpClient client, List<Artifact> artifacts)
132133
List<String> updatedArtifacts = new ArrayList<>();
133134

134135
for (Artifact artifact : artifacts) {
135-
String[] parts = artifact.getName().split("-");
136+
String[] parts = artifact.name().split("-");
136137
StringBuilder path = new StringBuilder();
137138
path.append(JAVA_DOCS_BASE_URL)
138139
.append(GROUP)
139140
.append("/")
140-
.append(artifact.getName())
141+
.append(artifact.name())
141142
.append("/")
142-
.append(artifact.getVersion())
143+
.append(artifact.version())
143144
.append("/")
144145
.append(String.join("/", parts))
145146
.append("/package-summary.html");
@@ -155,15 +156,15 @@ static List<String> crawlJavaDocs(HttpClient client, List<Artifact> artifacts)
155156
String.format(
156157
Locale.ROOT,
157158
"Crawl failed for %s with status code %d at URL %s\nResponse: %s",
158-
artifact.getName(),
159+
artifact.name(),
159160
crawlResponse.statusCode(),
160161
path,
161162
crawlResponse.body()));
162163
continue;
163164
}
164165

165166
if (crawlResponse.body().contains(JAVA_DOC_DOWNLOADED_TEXT)) {
166-
updatedArtifacts.add(artifact.getName());
167+
updatedArtifacts.add(artifact.name());
167168
}
168169

169170
Thread.sleep(THROTTLE_MS); // some light throttling

0 commit comments

Comments
 (0)