Skip to content

Commit 6e304de

Browse files
committed
fix rebase
1 parent 0af474e commit 6e304de

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ public static OpenTelemetrySdk create(OpenTelemetryConfigurationModel configurat
109109
public static OpenTelemetrySdk create(
110110
OpenTelemetryConfigurationModel configurationModel, ComponentLoader componentLoader) {
111111
SpiHelper spiHelper = SpiHelper.create(componentLoader);
112-
for (OpenTelemetryConfigurationModelCustomizerProvider provider :
113-
spiHelper.loadOrdered(OpenTelemetryConfigurationModelCustomizerProvider.class)) {
112+
for (DeclarativeConfigurationCustomizerProvider provider :
113+
spiHelper.loadOrdered(DeclarativeConfigurationCustomizerProvider.class)) {
114114
configurationModel = provider.customize(configurationModel);
115115
}
116116
return createAndMaybeCleanup(

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationModelCustomizerProvider.java renamed to sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigurationCustomizerProvider.java

File renamed without changes.

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigurationCreateTest.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import io.opentelemetry.sdk.OpenTelemetrySdk;
1818
import io.opentelemetry.sdk.autoconfigure.internal.ComponentLoader;
1919
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
20-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException;
2120
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.AttributeNameValueModel;
2221
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
2322
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ResourceModel;
@@ -73,7 +72,7 @@ void parseAndCreate_Examples(@TempDir Path tempDir)
7372
tempDir, "clientCertificate.cert", clientTls.certificate().getEncoded());
7473

7574
File examplesDir = new File(System.getenv("CONFIG_EXAMPLE_DIR"));
76-
assertThat(examplesDir.isDirectory()).isTrue();
75+
assertThat(examplesDir).isDirectory();
7776

7877
for (File example : Objects.requireNonNull(examplesDir.listFiles())) {
7978
// Skip anchors.yaml because support for merge (i.e. "<<: *anchor") was explicitly removed in
@@ -174,15 +173,15 @@ void create_ModelCustomizer() {
174173
Collections.singletonList(
175174
new SpanProcessorModel().withAdditionalProperty("test", null))));
176175
ComponentLoader componentLoader =
177-
SpiHelper.serviceComponentLoader(FileConfiguration.class.getClassLoader());
176+
SpiHelper.serviceComponentLoader(DeclarativeConfiguration.class.getClassLoader());
178177
OpenTelemetrySdk sdk =
179-
FileConfiguration.create(
178+
DeclarativeConfiguration.create(
180179
model,
181180
new ComponentLoader() {
182181
@SuppressWarnings("unchecked")
183182
@Override
184183
public <T> Iterable<T> load(Class<T> spiClass) {
185-
if (OpenTelemetryConfigurationModelCustomizerProvider.class.equals(spiClass)) {
184+
if (DeclarativeConfigurationCustomizerProvider.class.equals(spiClass)) {
186185
return (Iterable<T>) Collections.singletonList(getCustomizerProvider());
187186
}
188187
return componentLoader.load(spiClass);
@@ -201,7 +200,7 @@ public <T> Iterable<T> load(Class<T> spiClass) {
201200
+ "telemetry.sdk.version=\"1.48.0-SNAPSHOT\"}}");
202201
}
203202

204-
private static OpenTelemetryConfigurationModelCustomizerProvider getCustomizerProvider() {
203+
private static DeclarativeConfigurationCustomizerProvider getCustomizerProvider() {
205204
return model -> {
206205
ResourceModel resource = model.getResource();
207206
if (resource == null) {

0 commit comments

Comments
 (0)