Skip to content

Commit 758b820

Browse files
committed
try and fix ci by removing record type and excluding tests on systems lower than 17
1 parent f59ac04 commit 758b820

File tree

3 files changed

+30
-6
lines changed

3 files changed

+30
-6
lines changed

javadoc-crawler/build.gradle.kts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,14 @@ tasks {
1717
options.release.set(17)
1818
}
1919

20+
// only test on java 17+
21+
val testJavaVersion: String? by project
22+
if (testJavaVersion != null && Integer.valueOf(testJavaVersion) < 17) {
23+
test {
24+
enabled = false
25+
}
26+
}
27+
2028
val crawl by registering(JavaExec::class) {
2129
dependsOn(classes)
2230

javadoc-crawler/src/main/java/io/opentelemetry/javadocs/Artifact.java

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,20 @@
55

66
package io.opentelemetry.javadocs;
77

8-
record Artifact(String name, String version) {}
8+
public class Artifact {
9+
private final String name;
10+
private final String version;
11+
12+
public Artifact(String name, String version) {
13+
this.name = name;
14+
this.version = version;
15+
}
16+
17+
public String getName() {
18+
return name;
19+
}
20+
21+
public String getVersion() {
22+
return version;
23+
}
24+
}

javadoc-crawler/src/main/java/io/opentelemetry/javadocs/JavaDocsCrawler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,14 +132,14 @@ static List<String> crawlJavaDocs(HttpClient client, List<Artifact> artifacts)
132132
List<String> updatedArtifacts = new ArrayList<>();
133133

134134
for (Artifact artifact : artifacts) {
135-
String[] parts = artifact.name().split("-");
135+
String[] parts = artifact.getName().split("-");
136136
StringBuilder path = new StringBuilder();
137137
path.append(JAVA_DOCS_BASE_URL)
138138
.append(GROUP)
139139
.append("/")
140-
.append(artifact.name())
140+
.append(artifact.getName())
141141
.append("/")
142-
.append(artifact.version())
142+
.append(artifact.getVersion())
143143
.append("/")
144144
.append(String.join("/", parts))
145145
.append("/package-summary.html");
@@ -155,15 +155,15 @@ static List<String> crawlJavaDocs(HttpClient client, List<Artifact> artifacts)
155155
String.format(
156156
Locale.ROOT,
157157
"Crawl failed for %s with status code %d at URL %s\nResponse: %s",
158-
artifact.name(),
158+
artifact.getName(),
159159
crawlResponse.statusCode(),
160160
path,
161161
crawlResponse.body()));
162162
continue;
163163
}
164164

165165
if (crawlResponse.body().contains(JAVA_DOC_DOWNLOADED_TEXT)) {
166-
updatedArtifacts.add(artifact.name());
166+
updatedArtifacts.add(artifact.getName());
167167
}
168168

169169
Thread.sleep(THROTTLE_MS); // some light throttling

0 commit comments

Comments
 (0)