Deprecate StatusData.isUnset (#2500)

* Deprecate StatusData.isUnset

* Cleanup

* option 2

Author: Anuraag Agrawal

exporters/jaeger-thrift/src/main/java/io/opentelemetry/exporter/jaeger/thrift/Adapter.java

@@ -104,7 +104,7 @@ static Span toJaeger(SpanData span) {
               .setVStr(span.getStatus().getDescription()));
     }
 
-    if (!span.getStatus().isUnset()) {
+    if (span.getStatus().getStatusCode() != StatusCode.UNSET) {
       tags.add(
           new Tag(KEY_SPAN_STATUS_CODE, TagType.STRING)
               .setVStr(span.getStatus().getStatusCode().name()));

exporters/jaeger/src/main/java/io/opentelemetry/exporter/jaeger/Adapter.java

@@ -104,7 +104,7 @@ static Model.Span toJaeger(SpanData span) {
               .build());
     }
 
-    if (!span.getStatus().isUnset()) {
+    if (span.getStatus().getStatusCode() != StatusCode.UNSET) {
       target.addTags(
           Model.KeyValue.newBuilder()
               .setKey(KEY_SPAN_STATUS_CODE)

exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/ZipkinSpanExporter.java

@@ -12,6 +12,7 @@
 import io.opentelemetry.api.common.AttributeType;
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.trace.Span.Kind;
+import io.opentelemetry.api.trace.StatusCode;
 import io.opentelemetry.sdk.common.CompletableResultCode;
 import io.opentelemetry.sdk.common.InstrumentationLibraryInfo;
 import io.opentelemetry.sdk.resources.ResourceAttributes;
@@ -131,11 +132,11 @@ static Span generateSpan(SpanData spanData, Endpoint localEndpoint) {
     StatusData status = spanData.getStatus();
 
     // include status code & error.
-    if (!status.isUnset()) {
+    if (status.getStatusCode() != StatusCode.UNSET) {
       spanBuilder.putTag(OTEL_STATUS_CODE, status.getStatusCode().toString());
 
       // add the error tag, if it isn't already in the source span.
-      if (!status.isOk() && spanAttributes.get(STATUS_ERROR) == null) {
+      if (status.getStatusCode() == StatusCode.ERROR && spanAttributes.get(STATUS_ERROR) == null) {
         spanBuilder.putTag(STATUS_ERROR.getKey(), nullToEmpty(status.getDescription()));
       }
     }

sdk-extensions/zpages/src/main/java/io/opentelemetry/sdk/extension/zpages/TracezSpanBuckets.java

@@ -31,7 +31,7 @@ final class TracezSpanBuckets {
 
   void addToBucket(ReadableSpan span) {
     StatusData status = span.toSpanData().getStatus();
-    if (status.isOk()) {
+    if (status.getStatusCode() != StatusCode.ERROR) {
       latencyBuckets.get(LatencyBoundary.getBoundary(span.getLatencyNanos())).add(span);
       return;
     }

sdk/trace/src/main/java/io/opentelemetry/sdk/trace/data/StatusData.java

@@ -56,8 +56,10 @@ static StatusData create(StatusCode code, @Nullable String description) {
    * Returns {@code true} if this {@code Status} is UNSET, i.e., not an error.
    *
    * @return {@code true} if this {@code Status} is UNSET.
+   * @deprecated Compare {@link #getStatusCode()} with {@link StatusCode#UNSET}
    */
   // TODO: Consider to remove this in a future PR. Avoid too many changes in the initial PR.
+  @Deprecated
   default boolean isUnset() {
     return StatusCode.UNSET == getStatusCode();
   }
@@ -67,8 +69,9 @@ default boolean isUnset() {
    * overridden to be ok by an operator.
    *
    * @return {@code true} if this {@code Status} is OK or UNSET.
+   * @deprecated Compare {@link #getStatusCode()} with {@link StatusCode#ERROR}
    */
-  // TODO: Consider to remove this in a future PR. Avoid too many changes in the initial PR.
+  @Deprecated
   default boolean isOk() {
     return isUnset() || StatusCode.OK == getStatusCode();
   }