Skip to content

Commit 919df87

Browse files
committed
polish: restructuring code as pr feedback.
1 parent 679dd73 commit 919df87

15 files changed

+23
-28
lines changed

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/data/ExponentialHistogramBuckets.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@
2626
@Immutable
2727
public interface ExponentialHistogramBuckets {
2828

29-
/**
30-
* Create a ExponentialHistogramBuckets.
31-
*
32-
* @return a ExponentialHistogramBuckets.
33-
*/
3429
static ExponentialHistogramBuckets create(int scale, int offset, List<Long> bucketCounts) {
3530
return ImmutableExponentialHistogramBuckets.create(scale, offset, bucketCounts);
3631
}

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/DoubleExemplarDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import io.opentelemetry.api.trace.TraceState;
1515
import org.junit.jupiter.api.Test;
1616

17-
public class DoubleExemplarDataTest {
17+
class DoubleExemplarDataTest {
1818

1919
private static final String TRACE_ID = "00000000000000000000000000000061";
2020
private static final String SPAN_ID = "0000000000000061";

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/DoublePointDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import java.util.Collections;
1212
import org.junit.jupiter.api.Test;
1313

14-
public class DoublePointDataTest {
14+
class DoublePointDataTest {
1515

1616
@Test
1717
void create() {

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/ExponentialHistogramBucketsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import java.util.Arrays;
1111
import org.junit.jupiter.api.Test;
1212

13-
public class ExponentialHistogramBucketsTest {
13+
class ExponentialHistogramBucketsTest {
1414

1515
@Test
1616
void create() {

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/ExponentialHistogramDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import java.util.Collections;
1111
import org.junit.jupiter.api.Test;
1212

13-
public class ExponentialHistogramDataTest {
13+
class ExponentialHistogramDataTest {
1414

1515
@Test
1616
void create() {

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/ExponentialHistogramPointDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import java.util.Collections;
1818
import org.junit.jupiter.api.Test;
1919

20-
public class ExponentialHistogramPointDataTest {
20+
class ExponentialHistogramPointDataTest {
2121

2222
@Test
2323
void create() {

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/GaugeDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import java.util.Collections;
1212
import org.junit.jupiter.api.Test;
1313

14-
public class GaugeDataTest {
14+
class GaugeDataTest {
1515

1616
@Test
1717
void createLongGaugeData() {

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/HistogramDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import java.util.Collections;
1111
import org.junit.jupiter.api.Test;
1212

13-
public class HistogramDataTest {
13+
class HistogramDataTest {
1414

1515
@Test
1616
void create() {

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/HistogramPointDataTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import java.util.ArrayList;
1313
import org.junit.jupiter.api.Test;
1414

15-
public class HistogramPointDataTest {
15+
class HistogramPointDataTest {
1616

1717
@Test
1818
void create() {
@@ -21,21 +21,21 @@ void create() {
2121
0,
2222
0,
2323
Attributes.empty(),
24-
0.0,
24+
3.0,
2525
/* hasMin= */ false,
26-
0.0,
26+
1.0,
2727
/* hasMax= */ false,
28-
0.0,
28+
2.0,
2929
new ArrayList<>(),
3030
ImmutableList.of(0L));
3131
assertThat(pointData.getStartEpochNanos()).isEqualTo(0);
3232
assertThat(pointData.getEpochNanos()).isEqualTo(0);
3333
assertThat(pointData.getAttributes()).isEqualTo(Attributes.empty());
34-
assertThat(pointData.getSum()).isEqualTo(0.0);
34+
assertThat(pointData.getSum()).isEqualTo(3.0);
3535
assertThat(pointData.getCount()).isEqualTo(0);
3636
assertThat(pointData.hasMin()).isFalse();
37-
assertThat(pointData.getMin()).isEqualTo(0.0);
37+
assertThat(pointData.getMin()).isEqualTo(1.0);
3838
assertThat(pointData.hasMax()).isFalse();
39-
assertThat(pointData.getMax()).isEqualTo(0.0);
39+
assertThat(pointData.getMax()).isEqualTo(2.0);
4040
}
4141
}

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/data/LongExemplarDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import io.opentelemetry.api.trace.TraceState;
1414
import org.junit.jupiter.api.Test;
1515

16-
public class LongExemplarDataTest {
16+
class LongExemplarDataTest {
1717

1818
@Test
1919
void create() {

0 commit comments

Comments
 (0)