Skip to content

Commit cbc1183

Browse files
authored
Add slightly more strict test verifiction (#7595)
1 parent ab8d930 commit cbc1183

File tree

5 files changed

+14
-2
lines changed

5 files changed

+14
-2
lines changed

exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -988,6 +988,7 @@ void toBuilderEquality()
988988
assertThat(copy.unwrap())
989989
.extracting("builder")
990990
.usingRecursiveComparison()
991+
.withStrictTypeChecking()
991992
.ignoringFields("tlsConfigHelper")
992993
.isEqualTo(builderField.get(unwrapped));
993994
} finally {
@@ -1000,6 +1001,7 @@ void toBuilderEquality()
10001001
assertThat(copy.unwrap())
10011002
.extracting("builder")
10021003
.usingRecursiveComparison()
1004+
.withStrictTypeChecking()
10031005
.ignoringFields("tlsConfigHelper")
10041006
.isNotEqualTo(builderField.get(unwrapped));
10051007
} finally {

exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -850,6 +850,7 @@ void toBuilderEquality()
850850
assertThat(copy.unwrap())
851851
.extracting("builder")
852852
.usingRecursiveComparison()
853+
.withStrictTypeChecking()
853854
.ignoringFields("tlsConfigHelper")
854855
.isEqualTo(builderField.get(unwrapped));
855856
} finally {
@@ -862,6 +863,7 @@ void toBuilderEquality()
862863
assertThat(copy.unwrap())
863864
.extracting("builder")
864865
.usingRecursiveComparison()
866+
.withStrictTypeChecking()
865867
.ignoringFields("tlsConfigHelper")
866868
.isNotEqualTo(builderField.get(unwrapped));
867869
} finally {

sdk/logs/src/test/java/io/opentelemetry/sdk/logs/LogLimitsTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ void updateLogLimits_All() {
2929
// Preserves values
3030
LogLimits logLimitsDupe = logLimits.toBuilder().build();
3131
// Use reflective comparison to catch when new fields are added.
32-
assertThat(logLimitsDupe).usingRecursiveComparison().isEqualTo(logLimits);
32+
assertThat(logLimitsDupe)
33+
.usingRecursiveComparison()
34+
.withStrictTypeChecking()
35+
.isEqualTo(logLimits);
3336
}
3437

3538
@Test

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/view/ViewRegistryTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -488,6 +488,7 @@ void findViews_ApplyAdvice() {
488488
assertThat(view)
489489
.as("is the same as the default view, except the attributes processor")
490490
.usingRecursiveComparison()
491+
.withStrictTypeChecking()
491492
.ignoringFields("viewAttributesProcessor")
492493
.isEqualTo(DEFAULT_REGISTERED_VIEW);
493494
assertThat(view)
@@ -520,6 +521,7 @@ void findViews_ApplyAdvice() {
520521
assertThat(view)
521522
.as("is the same as the default view, except the attributes processor")
522523
.usingRecursiveComparison()
524+
.withStrictTypeChecking()
523525
.ignoringFields("viewAttributesProcessor")
524526
.isEqualTo(DEFAULT_REGISTERED_VIEW);
525527
assertThat(view)

sdk/trace/src/test/java/io/opentelemetry/sdk/trace/config/SpanLimitsTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,10 @@ void updateSpanLimits_All() {
4242
// Preserves values
4343
SpanLimits spanLimitsDupe = spanLimits.toBuilder().build();
4444
// Use reflective comparison to catch when new fields are added.
45-
assertThat(spanLimitsDupe).usingRecursiveComparison().isEqualTo(spanLimits);
45+
assertThat(spanLimitsDupe)
46+
.usingRecursiveComparison()
47+
.withStrictTypeChecking()
48+
.isEqualTo(spanLimits);
4649
}
4750

4851
@Test

0 commit comments

Comments
 (0)