Skip to content

Commit d45b6a8

Browse files
committed
Reverting some unnecessary changes.
Improved createResource method
1 parent db4e2e0 commit d45b6a8

File tree

2 files changed

+12
-20
lines changed

2 files changed

+12
-20
lines changed

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/IncubatingUtil.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,17 +83,23 @@ private static Resource createResourceFromModel(
8383
InvocationTargetException,
8484
IllegalAccessException,
8585
ClassNotFoundException {
86-
Class<?> declarativeConfigurationClass =
87-
Class.forName(
88-
"io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration");
8986
Class<?> configurationModelClass =
9087
Class.forName(
9188
"io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel");
89+
Method getResource = configurationModelClass.getMethod("getResource");
90+
Object resourceModel = getResource.invoke(openTelemetryConfigurationModel);
9291

92+
Class<?> resourceModelClass =
93+
Class.forName(
94+
"io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ResourceModel");
95+
Class<?> declarativeConfigurationClass =
96+
Class.forName(
97+
"io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration");
9398
Method createResource =
9499
declarativeConfigurationClass.getMethod(
95-
"createResource", configurationModelClass, ComponentLoader.class);
96-
return (Resource) createResource.invoke(null, openTelemetryConfigurationModel, componentLoader);
100+
"createResource", resourceModelClass, ComponentLoader.class);
101+
102+
return (Resource) createResource.invoke(null, resourceModel, componentLoader);
97103
}
98104

99105
private static ConfigurationException toConfigurationException(

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfiguration.java

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -111,20 +111,7 @@ public static OpenTelemetrySdk create(OpenTelemetryConfigurationModel configurat
111111
public static OpenTelemetrySdk create(
112112
OpenTelemetryConfigurationModel configurationModel, ComponentLoader componentLoader) {
113113
SpiHelper spiHelper = SpiHelper.create(componentLoader);
114-
return create(configurationModel, spiHelper);
115-
}
116114

117-
/**
118-
* Interpret the {@code configurationModel} to create {@link OpenTelemetrySdk} instance
119-
* corresponding to the configuration.
120-
*
121-
* @param configurationModel the configuration model
122-
* @param spiHelper the component loader used to load {@link ComponentProvider} implementations
123-
* @return the {@link OpenTelemetrySdk}
124-
* @throws DeclarativeConfigException if unable to interpret
125-
*/
126-
public static OpenTelemetrySdk create(
127-
OpenTelemetryConfigurationModel configurationModel, SpiHelper spiHelper) {
128115
DeclarativeConfigurationBuilder builder = new DeclarativeConfigurationBuilder();
129116

130117
for (DeclarativeConfigurationCustomizerProvider provider :
@@ -222,8 +209,7 @@ public static Sampler createSampler(DeclarativeConfigProperties genericSamplerMo
222209

223210
/** Create a {@link Resource} from the {@code resourceModel} representing the resource config. */
224211
public static Resource createResource(
225-
OpenTelemetryConfigurationModel model, ComponentLoader componentLoader) {
226-
ResourceModel resourceModel = model.getResource();
212+
ResourceModel resourceModel, ComponentLoader componentLoader) {
227213
if (resourceModel == null) {
228214
return Resource.getDefault();
229215
}

0 commit comments

Comments
 (0)