Reduce visibility, remove propagateContextForTesting

Author: jack-berg

exporters/sender/jdk/src/main/java/io/opentelemetry/exporter/sender/jdk/internal/JdkHttpSender.java

@@ -75,23 +75,6 @@ public final class JdkHttpSender implements HttpSender {
   @Nullable private final RetryPolicy retryPolicy;
   private final Predicate<IOException> retryExceptionPredicate;
 
-  /**
-   * Returns an {@link ExecutorService} using daemon threads.
-   *
-   * @param propagateContextForTesting For tests only. When enabled, the current thread's Context
-   *     will be passed over to the new threads, this is useful for validating scenarios where
-   *     context propagation is available through bytecode instrumentation.
-   */
-  public static ExecutorService newExecutor(boolean propagateContextForTesting) {
-    return new ThreadPoolExecutor(
-        0,
-        Integer.MAX_VALUE,
-        60,
-        TimeUnit.SECONDS,
-        new SynchronousQueue<>(),
-        new DaemonThreadFactory("jdkhttp-executor", propagateContextForTesting));
-  }
-
   // Visible for testing
   JdkHttpSender(
       HttpClient client,
@@ -102,8 +85,7 @@ public static ExecutorService newExecutor(boolean propagateContextForTesting) {
       long timeoutNanos,
       Supplier<Map<String, List<String>>> headerSupplier,
       @Nullable RetryPolicy retryPolicy,
-      @Nullable ExecutorService executorService,
-      boolean propagateContextForTesting) {
+      @Nullable ExecutorService executorService) {
     this.client = client;
     try {
       this.uri = new URI(endpoint);
@@ -121,7 +103,7 @@ public static ExecutorService newExecutor(boolean propagateContextForTesting) {
             .map(RetryPolicy::getRetryExceptionPredicate)
             .orElse(JdkHttpSender::isRetryableException);
     if (executorService == null) {
-      this.executorService = JdkHttpSender.newExecutor(propagateContextForTesting);
+      this.executorService = newExecutor();
       this.managedExecutor = true;
     } else {
       this.executorService = executorService;
@@ -150,8 +132,17 @@ public static ExecutorService newExecutor(boolean propagateContextForTesting) {
         timeoutNanos,
         headerSupplier,
         retryPolicy,
-        executorService,
-        /* propagateContextForTesting= */ false);
+        executorService);
+  }
+
+  private static ExecutorService newExecutor() {
+    return new ThreadPoolExecutor(
+        0,
+        Integer.MAX_VALUE,
+        60,
+        TimeUnit.SECONDS,
+        new SynchronousQueue<>(),
+        new DaemonThreadFactory("jdkhttp-executor"));
   }
 
   private static HttpClient configureClient(

exporters/sender/jdk/src/test/java/io/opentelemetry/exporter/sender/jdk/internal/JdkHttpSenderTest.java

@@ -63,8 +63,7 @@ void setup() throws IOException, InterruptedException {
             Duration.ofSeconds(10).toNanos(),
             Collections::emptyMap,
             RetryPolicy.builder().setMaxAttempts(2).setInitialBackoff(Duration.ofMillis(1)).build(),
-            null,
-            true);
+            null);
   }
 
   @Test
@@ -90,8 +89,7 @@ void sendInternal_RetryableConnectException() throws IOException, InterruptedExc
             Duration.ofSeconds(10).toNanos(),
             Collections::emptyMap,
             RetryPolicy.builder().setMaxAttempts(2).setInitialBackoff(Duration.ofMillis(1)).build(),
-            null,
-            true);
+            null);
 
     assertThatThrownBy(() -> sender.sendInternal(new NoOpMarshaler()))
         .satisfies(