Skip to content

Commit daa8e38

Browse files
committed
Remove ExtendedLogRecordBuilder#setException
1 parent 7a62f68 commit daa8e38

File tree

5 files changed

+0
-129
lines changed

5 files changed

+0
-129
lines changed

api/incubator/src/main/java/io/opentelemetry/api/incubator/logs/ExtendedDefaultLogger.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@ public ExtendedLogRecordBuilder setEventName(String eventName) {
4040
return this;
4141
}
4242

43-
@Override
44-
public ExtendedLogRecordBuilder setException(Throwable throwable) {
45-
return this;
46-
}
47-
4843
@Override
4944
public LogRecordBuilder setTimestamp(long timestamp, TimeUnit unit) {
5045
return this;

api/incubator/src/main/java/io/opentelemetry/api/incubator/logs/ExtendedLogRecordBuilder.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,4 @@ public interface ExtendedLogRecordBuilder extends LogRecordBuilder {
1919
* record with a non-empty event name is an Event.
2020
*/
2121
ExtendedLogRecordBuilder setEventName(String eventName);
22-
23-
/** Set standard {@code exception.*} attributes based on the {@code throwable}. */
24-
ExtendedLogRecordBuilder setException(Throwable throwable);
2522
}

sdk/logs/src/main/java/io/opentelemetry/sdk/logs/ExtendedSdkLogRecordBuilder.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ public ExtendedSdkLogRecordBuilder setEventName(String eventName) {
2929
return this;
3030
}
3131

32-
@Override
33-
public ExtendedSdkLogRecordBuilder setException(Throwable throwable) {
34-
super.setException(throwable);
35-
return this;
36-
}
37-
3832
@Override
3933
public ExtendedSdkLogRecordBuilder setTimestamp(long timestamp, TimeUnit unit) {
4034
super.setTimestamp(timestamp, unit);

sdk/logs/src/main/java/io/opentelemetry/sdk/logs/SdkLogRecordBuilder.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@
55

66
package io.opentelemetry.sdk.logs;
77

8-
import static io.opentelemetry.sdk.internal.ExceptionAttributeResolver.EXCEPTION_MESSAGE;
9-
import static io.opentelemetry.sdk.internal.ExceptionAttributeResolver.EXCEPTION_STACKTRACE;
10-
import static io.opentelemetry.sdk.internal.ExceptionAttributeResolver.EXCEPTION_TYPE;
11-
128
import io.opentelemetry.api.common.AttributeKey;
139
import io.opentelemetry.api.common.Value;
1410
import io.opentelemetry.api.logs.LogRecordBuilder;
@@ -17,7 +13,6 @@
1713
import io.opentelemetry.context.Context;
1814
import io.opentelemetry.sdk.common.InstrumentationScopeInfo;
1915
import io.opentelemetry.sdk.internal.AttributesMap;
20-
import io.opentelemetry.sdk.internal.ExceptionAttributeResolver;
2116
import java.time.Instant;
2217
import java.util.concurrent.TimeUnit;
2318
import javax.annotation.Nullable;
@@ -51,28 +46,6 @@ SdkLogRecordBuilder setEventName(String eventName) {
5146
return this;
5247
}
5348

54-
// accessible via ExtendedSdkLogRecordBuilder
55-
SdkLogRecordBuilder setException(Throwable throwable) {
56-
if (throwable == null) {
57-
return this;
58-
}
59-
ExceptionAttributeResolver exceptionAttributeResolver =
60-
loggerSharedState.getExceptionAttributeResolver();
61-
String type = exceptionAttributeResolver.getExceptionType(throwable);
62-
if (type != null) {
63-
setAttribute(EXCEPTION_TYPE, type);
64-
}
65-
String message = exceptionAttributeResolver.getExceptionMessage(throwable);
66-
if (message != null) {
67-
setAttribute(EXCEPTION_MESSAGE, message);
68-
}
69-
String stacktrace = exceptionAttributeResolver.getExceptionStacktrace(throwable);
70-
if (stacktrace != null) {
71-
setAttribute(EXCEPTION_STACKTRACE, stacktrace);
72-
}
73-
return this;
74-
}
75-
7649
@Override
7750
public SdkLogRecordBuilder setTimestamp(long timestamp, TimeUnit unit) {
7851
this.timestampEpochNanos = unit.toNanos(timestamp);

sdk/logs/src/testIncubating/java/io/opentelemetry/sdk/logs/ExtendedLoggerBuilderTest.java

Lines changed: 0 additions & 88 deletions
This file was deleted.

0 commit comments

Comments
 (0)