Change the usage of MMSC aggregations to always be deltas. (#1368)

Author: jkwatson

sdk/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueRecorderSdk.java

@@ -35,7 +35,7 @@ private DoubleValueRecorderSdk(
         meterProviderSharedState,
         meterSharedState,
         new ActiveBatcher(
-            Batchers.getCumulativeAllLabels(
+            Batchers.getDeltaAllLabels(
                 descriptor,
                 meterProviderSharedState,
                 meterSharedState,

sdk/src/main/java/io/opentelemetry/sdk/metrics/LongValueRecorderSdk.java

@@ -35,7 +35,7 @@ private LongValueRecorderSdk(
         meterProviderSharedState,
         meterSharedState,
         new ActiveBatcher(
-            Batchers.getCumulativeAllLabels(
+            Batchers.getDeltaAllLabels(
                 descriptor,
                 meterProviderSharedState,
                 meterSharedState,

sdk/src/test/java/io/opentelemetry/sdk/metrics/DoubleValueRecorderSdkTest.java

@@ -185,7 +185,7 @@ public void collectMetrics_WithMultipleCollects() {
                   323.3d,
                   valueAtPercentiles(-121.5d, 321.5d)));
 
-      // Repeat to prove we keep previous values.
+      // Repeat to prove we don't keep previous values.
       testClock.advanceNanos(SECOND_NANOS);
       boundMeasure.record(222d);
       doubleMeasure.record(17d, Labels.empty());
@@ -197,19 +197,19 @@ public void collectMetrics_WithMultipleCollects() {
       assertThat(metricData.getPoints())
           .containsExactly(
               SummaryPoint.create(
-                  startTime,
+                  startTime + SECOND_NANOS,
                   secondCollect,
                   Labels.empty(),
-                  3,
-                  16.0d,
-                  valueAtPercentiles(-13.1d, 17d)),
+                  1,
+                  17.0d,
+                  valueAtPercentiles(17d, 17d)),
               SummaryPoint.create(
-                  startTime,
+                  startTime + SECOND_NANOS,
                   secondCollect,
                   Labels.of("K", "V"),
-                  4,
-                  545.3d,
-                  valueAtPercentiles(-121.5, 321.5d)));
+                  1,
+                  222.0d,
+                  valueAtPercentiles(222.0, 222.0d)));
     } finally {
       boundMeasure.unbind();
     }

sdk/src/test/java/io/opentelemetry/sdk/metrics/LongValueRecorderSdkTest.java

@@ -180,7 +180,7 @@ public void collectMetrics_WithMultipleCollects() {
                   323,
                   valueAtPercentiles(-121, 321)));
 
-      // Repeat to prove we keep previous values.
+      // Repeat to prove we don't keep previous values.
       testClock.advanceNanos(SECOND_NANOS);
       boundMeasure.record(222);
       longMeasure.record(17, Labels.empty());
@@ -193,14 +193,19 @@ public void collectMetrics_WithMultipleCollects() {
       assertThat(metricData.getPoints())
           .containsExactly(
               SummaryPoint.create(
-                  startTime, secondCollect, Labels.empty(), 3, 15, valueAtPercentiles(-14, 17)),
+                  startTime + SECOND_NANOS,
+                  secondCollect,
+                  Labels.empty(),
+                  1,
+                  17,
+                  valueAtPercentiles(17, 17)),
               SummaryPoint.create(
-                  startTime,
+                  startTime + SECOND_NANOS,
                   secondCollect,
                   Labels.of("K", "V"),
-                  4,
-                  545,
-                  valueAtPercentiles(-121, 321)));
+                  1,
+                  222,
+                  valueAtPercentiles(222, 222)));
     } finally {
       boundMeasure.unbind();
     }