Sample rate

[stnor]

I think I'm seeing 100% sample rate in my app...

I'm using:
-javaagent:/opt/aws-opentelemetry-agent-1.1.0.jar -Dotel.resource.attributes=service.name=xxx -Dotel.instrumentation.jdbc-datasource.enabled=true -Dotel.instrumentation.opentelemetry-annotations.enabled=true -Dotel.traces.sampler.traceidratio=true -Dotel.traces.sampler.arg=0.005

I would expect a 1/200 sample rate with that config, but I'm pretty sure it's at 100%. Is the syntax correct?

Ideally I'd love to set a number of samples per time unit rather than a percentage.

[jkwatson]

hm. this isn't a thing: -Dotel.traces.sampler.traceidratio .

You want: -Dotel.traces.sampler=traceidratio

Hope that helps.

[stnor]

Ah, cool. Thanks!

Do I need to worry about this: #2432 ?

[jkwatson]

Nope. Using -Dotel.traces.sample.arg=0.005 is the correct way to do it.

BTW, you might want to consider using parentbased_traceidratio so you keep traces that are being sampled upstream of you as well.

[stnor]

OK. cool. Thanks so much! You saved my evening! ❤️