-
Notifications
You must be signed in to change notification settings - Fork 932
Update benchmark runner #7532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update benchmark runner #7532
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7532 +/- ##
=========================================
Coverage 90.01% 90.01%
Complexity 7080 7080
=========================================
Files 803 803
Lines 21417 21417
Branches 2086 2086
=========================================
Hits 19278 19278
Misses 1477 1477
Partials 662 662 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
breedx-splk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!
jkwatson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
| runs-on: equinix-bare-metal | ||
| runs-on: oracle-bare-metal-64cpu-512gb-x86-64 | ||
| container: | ||
| image: ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaydeluca can you fix here too? thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thisis what i fixed in b2c476c, merged in https://github.com/open-telemetry/opentelemetry-java/pull/7559/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
The benchmark actions have not been running since July 27th, which looks to be related to open-telemetry/community#2801.
I picked the latest LTS ubuntu as the container as a starting point, but open to suggestions if we should use something more java specific, or if we want to try not using a container at all?
Some references from that other issue: