Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Aug 18, 2025

Pros:

  • running tests locally use the same version as CI
  • version is collocated in the test file
  • easily extendable to other images (one extra line in the renovate configuration)

Cons:

  • complex renovate rule
  • requires scanning test files which are normally ignored by renovate

cc @zeitlinger

@trask trask requested a review from a team as a code owner August 18, 2025 16:38
@trask trask force-pushed the maybe-simpler-renovate branch from fe98a10 to 8327c81 Compare August 18, 2025 22:28
'helpers:pinGitHubActionDigestsToSemver',
'customManagers:githubActionsVersions'
],
ignorePaths: [], // overwrite default ignore which includes **/test/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this particular rule, we only want to scan test paths, yes? Would it make renovate more efficient if we could encode that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didn't seem like you could change the ignorePaths per custom manager

I don't think the efficiency is the problem, more about Renovate picking up false positives, which luckily didn't seem to be a problem for this repo (I tested in my fork)

Copy link
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 😄

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.01%. Comparing base (20f0a3a) to head (acb36be).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7586   +/-   ##
=========================================
  Coverage     90.01%   90.01%           
  Complexity     7081     7081           
=========================================
  Files           803      803           
  Lines         21419    21419           
  Branches       2086     2086           
=========================================
  Hits          19280    19280           
  Misses         1477     1477           
  Partials        662      662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkwatson jkwatson merged commit e4a047a into open-telemetry:main Aug 20, 2025
49 of 50 checks passed
@trask trask deleted the maybe-simpler-renovate branch October 20, 2025 17:27
the-clam pushed a commit to the-clam/opentelemetry-java that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants