-
Notifications
You must be signed in to change notification settings - Fork 935
Alternate strategy for pinning collector images #7586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe98a10 to
8327c81
Compare
| 'helpers:pinGitHubActionDigestsToSemver', | ||
| 'customManagers:githubActionsVersions' | ||
| ], | ||
| ignorePaths: [], // overwrite default ignore which includes **/test/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this particular rule, we only want to scan test paths, yes? Would it make renovate more efficient if we could encode that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it didn't seem like you could change the ignorePaths per custom manager
I don't think the efficiency is the problem, more about Renovate picking up false positives, which luckily didn't seem to be a problem for this repo (I tested in my fork)
zeitlinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 😄
jkwatson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7586 +/- ##
=========================================
Coverage 90.01% 90.01%
Complexity 7081 7081
=========================================
Files 803 803
Lines 21419 21419
Branches 2086 2086
=========================================
Hits 19280 19280
Misses 1477 1477
Partials 662 662 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: otelbot <[email protected]>
Pros:
Cons:
cc @zeitlinger