Define optionalCompileOnly configuration #7157
Draft
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Feb 27, 2025
|
|
||
| compileOnly(project(":api:incubator")) | ||
| optionalCompileOnly(project(":api:incubator")) | ||
| compileOnly(project(":sdk:trace-shaded-deps")) |
Member
Author
There was a problem hiding this comment.
If we go in this direction, we'll need to decide when its appropriate for a dependency to be compileOnly vs. optionalCompileOnly.
Originally, I just updated gradle maven publishing to include all compileOnly dependencies as optional dependencies in pom.xml, but that resulted in these standard compileOnly annotation dependencies being included in every pom.xml, which doesn't seem right.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7157 +/- ##
=========================================
Coverage 89.85% 89.85%
Complexity 6622 6622
=========================================
Files 740 740
Lines 20007 20007
Branches 1968 1968
=========================================
Hits 17978 17978
Misses 1439 1439
Partials 590 590 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7119.
An alternative to #7137 that allows us to specify that certain compileOnly dependencies should be added to
pom.xmlwithscope=runtime,optional=true, without the complexity of gradle feature variants.cc @trask