Skip to content

Commit 0613b27

Browse files
authored
Merge branch 'main' into typeorm-instrumentation
2 parents 6420025 + 122b203 commit 0613b27

File tree

4 files changed

+6
-18
lines changed

4 files changed

+6
-18
lines changed

.github/component_owners.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ components:
1818
- kirrg001
1919
incubator/opentelemetry-sampler-aws-xray:
2020
- jj22ee
21+
- yiyuan-he
2122
metapackages/auto-configuration-propagators:
2223
- pichlermarc
2324
metapackages/auto-instrumentations-node:

incubator/opentelemetry-sampler-aws-xray/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
> This component is still in development and has not been released as an npm package.
44
5-
[component owners](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/.github/component_owners.yml): @jj22ee
5+
[component owners](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/.github/component_owners.yml): @jj22ee, @yiyuan-he
66

77
This module provides the remote/centralized sampler for AWS X-Ray.
88

plugins/node/instrumentation-fs/README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
[![NPM Published Version][npm-img]][npm-url]
44
[![Apache License][license-image]][license-image]
55

6-
This module provides automatic instrumentation for the [`fs`](http://nodejs.org/dist/latest/docs/api/fs.html) module, which may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package and is included in the [`@opentelemetry/auto-instrumentations-node`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node) bundle.
6+
This module provides automatic instrumentation for the [`fs`](http://nodejs.org/dist/latest/docs/api/fs.html) module, which can be registered using the [`@opentelemetry/instrumentation`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-instrumentation) package.
77

8-
If total installation size is not constrained, it is recommended to use the [`@opentelemetry/auto-instrumentations-node`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node) bundle with [@opentelemetry/sdk-node](`https://www.npmjs.com/package/@opentelemetry/sdk-node`) for the most seamless instrumentation experience.
9-
10-
Compatible with OpenTelemetry JS API and SDK `1.0+`.
8+
Compatible with OpenTelemetry JS API `1.3+`.
119

1210
See the full list of instrumented functions in [constants.ts](src/constants.ts);
1311

@@ -19,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-fs
1917

2018
## Supported Versions
2119

22-
- Node.js `>=14`
20+
- Node.js `>=18`
2321

2422
## Usage
2523

scripts/lint-readme.js

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,7 @@ if (!currentReadmeContent.includes(badgesToVerify)) {
6262
);
6363
}
6464

65-
if (isNode) {
66-
const distText = `If total installation size is not constrained, it is recommended to use the [\`@opentelemetry/auto-instrumentations-node\`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node) bundle with [@opentelemetry/sdk-node](\`https://www.npmjs.com/package/@opentelemetry/sdk-node\`) for the most seamless instrumentation experience.
67-
68-
Compatible with OpenTelemetry JS API and SDK \`1.0+\`.
69-
`
70-
71-
if (!currentReadmeContent.includes(distText)) {
72-
throw new Error(
73-
`README.md dist text is not valid. Please add the following text to the README.md file:\n\n${distText}`
74-
);
75-
}
76-
} else if (isWeb) {
65+
if (isWeb) {
7766
const distText = `If total installation size is not constrained, it is recommended to use the [\`@opentelemetry/auto-instrumentations-web\`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-web) bundle with [\`@opentelemetry/sdk-trace-web\`](https://www.npmjs.com/package/@opentelemetry/sdk-trace-web) for the most seamless instrumentation experience.
7867
7968
Compatible with OpenTelemetry JS API and SDK \`1.0+\`.

0 commit comments

Comments
 (0)