- update dependency versions. Test is changed to

  use new propery, instrumentationScope and replaced addSpanProcessor
  with new syntax of BasicTracerProvider constructor.

Author: sudarshan12s

plugins/node/opentelemetry-instrumentation-oracledb/package.json

@@ -34,7 +34,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=14"
+    "node": "^18.19.0 || >=20.6.0"
   },
   "files": [
     "build/src/**/*.js",
@@ -49,10 +49,10 @@
   },
   "devDependencies": {
     "@opentelemetry/api": "^1.3.0",
-    "@opentelemetry/context-async-hooks": "^1.8.0",
-    "@opentelemetry/contrib-test-utils": "^0.45.1",
-    "@opentelemetry/sdk-trace-base": "^1.8.0",
-    "@opentelemetry/sdk-trace-node": "^1.8.0",
+    "@opentelemetry/context-async-hooks": "^2.0.0",
+    "@opentelemetry/contrib-test-utils": "^0.46.0",
+    "@opentelemetry/sdk-trace-base": "^2.0.0",
+    "@opentelemetry/sdk-trace-node": "^2.0.0",
     "@types/mocha": "10.0.10",
     "@types/node": "18.18.14",
     "@types/sinon": "17.0.4",
@@ -63,10 +63,10 @@
     "safe-stable-stringify": "^2.4.1",
     "sinon": "15.2.0",
     "test-all-versions": "6.1.0",
-    "typescript": "4.4.4"
+    "typescript": "5.0.4"
   },
   "dependencies": {
-    "@opentelemetry/instrumentation": "^0.57.2",
+    "@opentelemetry/instrumentation": "^0.200.0",
     "@opentelemetry/semantic-conventions": "^1.27.0",
     "@types/oracledb": "6.5.2"
   },

plugins/node/opentelemetry-instrumentation-oracledb/test/oracle.test.ts

@@ -61,7 +61,9 @@ import {
 
 const memoryExporter = new InMemorySpanExporter();
 let contextManager: AsyncHooksContextManager;
-const provider = new BasicTracerProvider();
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 const tracer = provider.getTracer('external');
 const instrumentation = new OracleInstrumentation();
 instrumentation.enable();
@@ -259,7 +261,7 @@ const verifySpanData = (
   if (parentSpan) {
     testUtils.assertPropagation(span, parentSpan as unknown as Span);
   } else {
-    assert(span.parentSpanId === undefined);
+    assert(span.parentSpanContext?.spanId === undefined);
   }
 };
 
@@ -502,7 +504,6 @@ describe('oracledb', () => {
     }
     await doSetup();
     updateAttrSpanList(connection);
-    provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
     contextManager = new AsyncHooksContextManager().enable();
     context.setGlobalContextManager(contextManager);
     instrumentation.setTracerProvider(provider);
@@ -1307,19 +1308,21 @@ describe('oracledb', () => {
       );
       assert.strictEqual(!!tracer, true);
       assert.ok(tracer, 'Tracer instance should not be null');
-      assert.strictEqual(
-        tracer.instrumentationLibrary.name,
-        '@opentelemetry/instrumentation-oracledb'
-      );
-
       const res = await connection.execute(sql);
       try {
         assert.ok(res);
         verifySpans(null);
       } catch (e: any) {
         assert.ok(false, e.message);
       }
-      const spans = memoryExporter.getFinishedSpans();
+      const spans = memoryExporter.getFinishedSpans().filter(s => {
+        assert.strictEqual(
+          s.instrumentationScope.name,
+          '@opentelemetry/instrumentation-oracledb',
+          `Unexpected span name: ${s.instrumentationScope.name}`
+        );
+        return true;
+      });
       assert.strictEqual(spans.length, numExecSpans);
     });
   });