- Remove deprecated param, ATTR_DB_CONNECTION_STRING as per review

  suggestion

Author: sudarshan12s

plugins/node/opentelemetry-instrumentation-oracledb/src/OracleTelemetryTraceHandler.ts

@@ -36,7 +36,6 @@ import {
   ATTR_DB_OPERATION_NAME,
   ATTR_DB_STATEMENT,
   ATTR_DB_OPERATION_PARAMETER,
-  ATTR_DB_CONNECTION_STRING,
   ATTR_DB_USER,
 } from './semconv';
 
@@ -120,7 +119,6 @@ export function getOracleTelemetryTraceHandlerClass(
           config.pdbName,
           config.serviceName
         ),
-        [ATTR_DB_CONNECTION_STRING]: config.connectString,
         [ATTR_SERVER_ADDRESS]: config.hostName,
         [ATTR_SERVER_PORT]: config.port,
       };

plugins/node/opentelemetry-instrumentation-oracledb/src/semconv.ts

@@ -94,12 +94,6 @@ export const ATTR_DB_STATEMENT = 'db.query.text';
  */
 export const ATTR_DB_OPERATION_PARAMETER = 'db.operation.parameter';
 
-/**
- * The connection string used to connect to the database. It is recommended to remove embedded credentials.
- *
- */
-export const ATTR_DB_CONNECTION_STRING = 'db.connection_string';
-
 /**
  * Username for accessing the database.
  *

plugins/node/opentelemetry-instrumentation-oracledb/test/oracle.test.ts

@@ -52,7 +52,6 @@ import {
   ATTR_DB_STATEMENT,
   ATTR_DB_OPERATION_PARAMETER,
   ATTR_DB_USER,
-  ATTR_DB_CONNECTION_STRING,
   ATTR_DB_OPERATION_NAME,
 } from '../src/semconv';
 
@@ -122,7 +121,6 @@ let spanNamesList: string[]; // span names for roundtrips and public API spans.
 const DEFAULT_ATTRIBUTES = {
   [ATTR_DB_SYSTEM]: DB_SYSTEM_VALUE_ORACLE,
   [ATTR_DB_NAMESPACE]: serviceName,
-  [ATTR_DB_CONNECTION_STRING]: CONFIG.connectString,
   [ATTR_SERVER_ADDRESS]: hostname,
   [ATTR_SERVER_PORT]: pno,
   [ATTR_DB_USER]: CONFIG.user,
@@ -134,19 +132,16 @@ const DEFAULT_ATTRIBUTES = {
 const DEFAULT_ATTRIBUTES_THICK = {
   [ATTR_DB_SYSTEM]: DB_SYSTEM_VALUE_ORACLE,
   [ATTR_DB_NAMESPACE]: serviceName,
-  [ATTR_DB_CONNECTION_STRING]: CONFIG.connectString,
   [ATTR_DB_USER]: CONFIG.user,
 };
 
 const POOL_ATTRIBUTES = {
   [ATTR_DB_SYSTEM]: DB_SYSTEM_VALUE_ORACLE,
-  [ATTR_DB_CONNECTION_STRING]: CONFIG.connectString,
   [ATTR_DB_USER]: CONFIG.user,
 };
 
 const CONN_FAILED_ATTRIBUTES = {
   [ATTR_DB_SYSTEM]: DB_SYSTEM_VALUE_ORACLE,
-  [ATTR_DB_CONNECTION_STRING]: CONFIG.connectString,
   [ATTR_DB_USER]: CONFIG.user,
 };